Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some lints #1325

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Fix some lints #1325

merged 3 commits into from
Aug 29, 2024

Conversation

etiennebacher
Copy link
Contributor

Prework

Related GitHub issues and pull requests

Summary

This fixes some "lints", for example using more specific expect_ functions.

There are many changes but most of them are trivial:

  • use inherits() instead of "foo" %in% class(x)
  • use expect_named(), expect_null(), and other variants in tests
    etc.

@wlandau wlandau merged commit 94148d3 into ropensci:main Aug 29, 2024
7 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants