Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/rm retired spatial packages #51

Merged
merged 123 commits into from
Aug 23, 2023
Merged

Fix/rm retired spatial packages #51

merged 123 commits into from
Aug 23, 2023

Conversation

robitalec
Copy link
Member

Closes #50

@robitalec robitalec mentioned this pull request Aug 3, 2023
6 tasks
@robitalec robitalec mentioned this pull request Aug 3, 2023
6 tasks
@robitalec
Copy link
Member Author

With newest version of testthat, can reproduce the errors above

Error (test-group-polys.R:481:3): proportion within 0-100, area > 0
Error in `Ops.units(act$val, exp$val)`: cannot compare non-convertible units

Error due to very small numbers

waldo::compare(max(out_mcp$proportion), units::as_units(100, 'percent'))
`unclass(old)`: 100.000000009
`unclass(new)`: 100.000000000

@robitalec robitalec merged commit 293a7cb into main Aug 23, 2023
8 checks passed
@robitalec robitalec deleted the fix/rm-retired-spatial-pkgs branch August 23, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependency on retiring spatial infrastructure packages
1 participant