Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm unnecessary lines #43

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Rm unnecessary lines #43

merged 2 commits into from
Jul 26, 2022

Conversation

maelle
Copy link
Member

@maelle maelle commented Jul 26, 2022

@robitalec I think these lines came from a _pkgdown.yml inside the site (https://docs.ropensci.org/spatsoc/pkgdown.yml) but they should not be in the source configuration (admittedly a bit confusing 😅 ). We saw an error on https://ropensci.r-universe.dev/ui#builds that I was able to reproduce with pkgdown::check_pkgdown(). After merging this PR the build should be fixed.

@maelle maelle requested a review from robitalec July 26, 2022 06:26
Copy link
Member

@robitalec robitalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@robitalec
Copy link
Member

I removed some more lines, left around from before the rOpenSci docs. Thank you!

@robitalec robitalec merged commit 71283ed into master Jul 26, 2022
@robitalec robitalec deleted the pkgdown-fix branch July 26, 2022 11:39
@maelle
Copy link
Member Author

maelle commented Jul 26, 2022

Yay, thank you! Green icon now

@robitalec robitalec restored the pkgdown-fix branch March 3, 2023 22:40
@robitalec robitalec deleted the pkgdown-fix branch August 23, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants