force numeric threshold group_lines

ropensci · Sep 17, 2018 · 69061b3 · 69061b3
1 parent ad3a1a3
commit 69061b3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/R/group_lines.R b/R/group_lines.R
@@ -89,6 +89,8 @@ group_lines <-
     if (is.null(threshold)) {
       message('threshold missing, using 0 by default')
       threshold <- 0
+    } else if (!is.numeric(threshold)) {
+      stop('threshold must be numeric')
     } else if (threshold < 0) {
       stop('cannot provide a negative threshold')
     }

diff --git a/tests/testthat/test-group-lines.R b/tests/testthat/test-group-lines.R
@@ -205,6 +205,19 @@ test_that('threshold is correctly provided, or error', {
       sortBy = 'datetime'
     )
   )
+
+  expect_error(
+    group_lines(
+      DT = DT,
+      threshold = '0',
+      timegroup = 'timegroup',
+      id = 'ID',
+      coords = c('X', 'Y'),
+      projection = utm,
+      sortBy = 'datetime'
+    ),
+    'threshold must be numeric'
+  )
 })