fix adjust hour/minute/day for group_times with minutes

ropensci · Dec 12, 2018 · 16e28c6 · 16e28c6
1 parent 4f30ff1
commit 16e28c6
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/R/group_times.R b/R/group_times.R
@@ -197,10 +197,14 @@ group_times <- function(DT = NULL,
 
       dtm[, c('adjMinute', 'adjHour', 'adjDate') :=
             .(minutes, data.table::hour(itime), idate)]
-      dtm[data.table::hour(itime) == 23 &
-            minutes == 60,
-          c('adjMinute', 'adjHour', 'adjDate') :=
-            .(0, 0, idate + 1)]
+
+      dtm[minutes == 60L,
+          c('adjMinute', 'adjHour') :=
+            .(0L, adjHour + 1L)]
+
+      dtm[adjHour == 24L,
+      c('adjMinute', 'adjHour', 'adjDate') :=
+        .(0L, 0L, idate + 1)]
 
       dtm[, timegroup := .GRP,
           by = c('adjMinute', 'adjHour', 'adjDate')]