Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

spatsoc blog post #347

Merged
merged 7 commits into from
Dec 4, 2018
Merged

Conversation

robitalec
Copy link
Contributor

Hello @stefaniebutland,
Here's our draft for a blog post about spatsoc, recently onboarded rOpenSci package (issue #237).
Thanks!

@stefaniebutland
Copy link
Collaborator

Thanks @robitalec ! I'll review this and get you feedback on Wednesday

Copy link
Collaborator

@stefaniebutland stefaniebutland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This post is SUCH A PLEASURE to read. The intro motivation for the package will entice readers. Nice clear explanations e.g. of SNA. Really. The whole thing is So Good.

I have a couple of minor suggestions:

  • put spatsoc and package names in backticks spatsoc
  • could you open a couple of issues to signal what you're thinking is needed? The tone of the post is very welcoming, so having an open issue or two is good.
  • I'd love to include a caribou pic in tweet about this post, along with the matrix and graph. Could you share a link to one I can use? How do I credit the pic? (Of course you could add one to the post if you like - I think it would be a nice addition to a software post - they are, after all, the subject and give context. Completely up to you, but the caribou have my vote)
  • the comment about Alec's love of testing reminded me of this post by a first-time reviewer: https://ropensci.org/blog/2018/03/13/ode-to-testing/

Thank you for doing this @robitalec et al. This makes rOpenSci look good 😄

@robitalec
Copy link
Contributor Author

robitalec commented Nov 28, 2018

Thank you @stefaniebutland, really appreciate your feedback!

  • wrapped all package names in backticks

We will include a caribou picture, great idea.
I am sourcing one now from the lab, I should have it ready and included in the post today or tomorrow. I'll include credits there as well.

I had a feeling we should have a few open issues, so I updated our CONTRIBUTING and issue labels. I'll have a couple issues opened in the next day or two and link them at the bottom of the post as well.

Ahh that's a great post, thanks for the link! Makes me feel like we are missing music in our post... Ha!

@robitalec
Copy link
Contributor Author

robitalec commented Nov 29, 2018

  • added the caribou image
  • opened some issues, added a link

Just missing a link for the photographer's personal page!

@robitalec
Copy link
Contributor Author

  • added the links

Let us know if there is anything else!

@stefaniebutland
Copy link
Collaborator

Looks 💯thank you!

@stefaniebutland stefaniebutland merged commit 4f3a0ee into ropensci-archive:master Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants