[RF] Override TObject::Clone() in RooWorkspace

Many users expect to use `Clone()` to copy RooWorkspaces, but so far this resulted in corrupt workspaces because the `Clone()` function was not overridden.
root-project · Apr 11, 2023 · ad275f1 · ad275f1
1 parent 5f7c330
commit ad275f1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/roofit/roofitcore/inc/RooWorkspace.h b/roofit/roofitcore/inc/RooWorkspace.h
@@ -51,6 +51,8 @@ class RooWorkspace : public TNamed {
   RooWorkspace(const RooWorkspace& other) ;
   ~RooWorkspace() override ;
 
+  TObject *Clone(const char *newname="") const override;
+
   bool importClassCode(const char* pat="*", bool doReplace=false) ;
   bool importClassCode(TClass* theClass, bool doReplace=false) ;
 

diff --git a/roofit/roofitcore/src/RooWorkspace.cxx b/roofit/roofitcore/src/RooWorkspace.cxx
@@ -224,6 +224,16 @@ RooWorkspace::RooWorkspace(const RooWorkspace& other) :
 }
 
 
+/// TObject::Clone() needs to be overridden.
+TObject *RooWorkspace::Clone(const char *newname) const
+{
+   auto out = new RooWorkspace{*this};
+   if(newname && std::string(newname) != GetName()) {
+      out->SetName(newname);
+   }
+   return out;
+}
+
 
 ////////////////////////////////////////////////////////////////////////////////
 /// Workspace destructor