Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange the explicit mapper classes through lambdas #27

Closed
roookeee opened this issue Aug 27, 2019 · 3 comments
Closed

Exchange the explicit mapper classes through lambdas #27

roookeee opened this issue Aug 27, 2019 · 3 comments
Assignees
@roookeee
Labels
enhancement New feature or request semver-patch
Milestone
1.4.0

Comments

@roookeee
Copy link
Owner

roookeee commented Aug 27, 2019 •
edited
Loading

datus currently implements the Mapper<A,B> in two distinct classes for the mutable and immutable API. This is unnecessary as the Mapper<A,B> interface is a functional interface. As the mapper implementation classes are package private this is a non-breaking change that reduces the overall code size of datus while also opening up for future JVM optimizations in regards to lambdas. Some local JMH testing also showed minor performance benefits when using lambdas.
@roookeee roookeee added enhancement New feature or request semver-patch labels Aug 27, 2019
@roookeee roookeee self-assigned this Aug 27, 2019
@roookeee
Copy link
Owner Author

roookeee commented Aug 27, 2019 •
edited
Loading

Implementation is in branch issue-27 - will probably release 1.3.1 for this

@roookeee
Copy link
Owner Author

Will merge into develop soon but won't release as of yet (too little has changed to release 1.3.1 or 1.4.0)

roookeee added a commit that referenced this issue Sep 3, 2019
@roookeee
ISSUE-27(#27): Exchange the explicit mapper classes through lambdas
fcece69
@roookeee
Copy link
Owner Author

roookeee commented Sep 3, 2019

Merged into develop

@roookeee roookeee closed this as completed Sep 3, 2019
@roookeee roookeee added this to the 1.4.1 milestone Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roookeee roookeee

Labels
enhancement New feature or request semver-patch
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
1 participant
@roookeee