Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collections #964

Merged
merged 40 commits into from
Jul 5, 2024
Merged

Collections #964

merged 40 commits into from
Jul 5, 2024

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented Jun 28, 2024 •
edited
Loading

  • Collections added
  • Reactivity added to all covers

Closes #219

Depends on:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

Test Results

73 tests  ±0   73 ✅ ±0   20s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit ebaa5d6. ± Comparison against base commit 31fbb1b.

♻️ This comment has been updated with latest results.

@zurdi15 zurdi15 force-pushed the feature/collections branch 3 times, most recently from a50ced1 to 665dade Compare July 3, 2024 12:14
@zurdi15 zurdi15 self-assigned this Jul 3, 2024
@zurdi15 zurdi15 added the feature New feature or request label Jul 3, 2024
gantoine
gantoine requested changes Jul 4, 2024
View reviewed changes
backend/endpoints/collections.py Outdated Show resolved Hide resolved
backend/endpoints/collections.py Show resolved Hide resolved
backend/endpoints/collections.py Outdated Show resolved Hide resolved
backend/endpoints/search.py Show resolved Hide resolved
backend/handler/filesystem/resources_handler.py Show resolved Hide resolved
backend/models/collection.py Show resolved Hide resolved
frontend/src/components/Administration/Users/Table.vue Outdated Show resolved Hide resolved
frontend/src/components/common/SearchCover.vue Outdated Show resolved Hide resolved
frontend/src/views/Dashboard.vue Outdated Show resolved Hide resolved
zurdi15 and others added 5 commits July 4, 2024 18:56
@zurdi15 @gantoine
Update backend/endpoints/collections.py
0d5620e 
Co-authored-by: Georges-Antoine Assi <3247106+gantoine@users.noreply.github.com>
@zurdi15 @gantoine
Update backend/endpoints/collections.py
124e1e7 
Co-authored-by: Georges-Antoine Assi <3247106+gantoine@users.noreply.github.com>
@zurdi15 @gantoine
Update frontend/src/components/common/SearchCover.vue
3ac40e1 
Co-authored-by: Georges-Antoine Assi <3247106+gantoine@users.noreply.github.com>
@zurdi15
changes from PR comments
febc579
@zurdi15
fixed from PR comment
0bd4c6f
@zurdi15 zurdi15 requested a review from gantoine July 4, 2024 17:15
@zurdi15 zurdi15 mentioned this pull request Jul 4, 2024
Merged
gantoine
gantoine requested changes Jul 5, 2024
View reviewed changes
backend/endpoints/rom.py Show resolved Hide resolved
backend/handler/database/roms_handler.py Show resolved Hide resolved
frontend/src/stores/users.ts Outdated Show resolved Hide resolved
@zurdi15 @gantoine
Update frontend/src/stores/users.ts
3c658d0 
Co-authored-by: Georges-Antoine Assi <3247106+gantoine@users.noreply.github.com>
@zurdi15 zurdi15 requested a review from gantoine July 5, 2024 18:59
@zurdi15 zurdi15 merged commit 7c54a58 into master Jul 5, 2024
8 checks passed
@zurdi15 zurdi15 deleted the feature/collections branch July 5, 2024 19:12
@zurdi15 zurdi15 mentioned this pull request Jul 19, 2024
Merged
spiceratops referenced this pull request in spiceratops/k8s-gitops Jul 23, 2024
@spiceratops
feat(container): update image rommapp/romm to v3.3.0 (#865)
51dc5ca 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [rommapp/romm](https://togithub.com/rommapp/romm) | minor | `3.2.0` ->
`3.3.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>rommapp/romm (rommapp/romm)</summary>

### [`v3.3.0`](https://togithub.com/rommapp/romm/releases/tag/3.3.0)

[Compare
Source](https://togithub.com/rommapp/romm/compare/3.2.0...3.3.0)

#### What's Changed

- UI complete redesign by
[@&#8203;zurdi15](https://togithub.com/zurdi15) in
[https://github.com/rommapp/romm/pull/934](https://togithub.com/rommapp/romm/pull/934)
- Covers are now fetch in their 1080p version by
[@&#8203;zurdi15](https://togithub.com/zurdi15) in
[https://github.com/rommapp/romm/pull/934](https://togithub.com/rommapp/romm/pull/934)
- Now sibling roms can have different covers by
[@&#8203;zurdi15](https://togithub.com/zurdi15) in
[https://github.com/rommapp/romm/pull/934](https://togithub.com/rommapp/romm/pull/934)
- Screenshots are fetch in their big version by
[@&#8203;zurdi15](https://togithub.com/zurdi15) in
[https://github.com/rommapp/romm/pull/934](https://togithub.com/rommapp/romm/pull/934)
- Setup wizard added for new **RomM** installations by
[@&#8203;zurdi15](https://togithub.com/zurdi15) in
[https://github.com/rommapp/romm/pull/976](https://togithub.com/rommapp/romm/pull/976)
- Added collections by [@&#8203;zurdi15](https://togithub.com/zurdi15)
in
[https://github.com/rommapp/romm/pull/964](https://togithub.com/rommapp/romm/pull/964)
- Add favourites collection as special collection by
[@&#8203;zurdi15](https://togithub.com/zurdi15) in
[https://github.com/rommapp/romm/pull/977](https://togithub.com/rommapp/romm/pull/977)
- SteamGridDB integration. Roms and collections can be edited with a
SteamGridDB cover by [@&#8203;zurdi15](https://togithub.com/zurdi15) in
[https://github.com/rommapp/romm/pull/960](https://togithub.com/rommapp/romm/pull/960)
- Enhanced scan logs by [@&#8203;zurdi15](https://togithub.com/zurdi15)
in
[https://github.com/rommapp/romm/pull/965](https://togithub.com/rommapp/romm/pull/965)
- Select main sibling added for merged roms in gallery by
[@&#8203;zurdi15](https://togithub.com/zurdi15) in
[https://github.com/rommapp/romm/pull/963](https://togithub.com/rommapp/romm/pull/963)
- Allow users to edit their own profile by
[@&#8203;zurdi15](https://togithub.com/zurdi15) in
[https://github.com/rommapp/romm/pull/975](https://togithub.com/rommapp/romm/pull/975)
- Fixed firmware drawer permissions by
[@&#8203;zurdi15](https://togithub.com/zurdi15) in
[https://github.com/rommapp/romm/pull/956](https://togithub.com/rommapp/romm/pull/956)
- Added total filesize endpoint by
[@&#8203;adamantike](https://togithub.com/adamantike) in
[https://github.com/rommapp/romm/pull/969](https://togithub.com/rommapp/romm/pull/969)
- Improved Docker image size by
[@&#8203;adamantike](https://togithub.com/adamantike) in
[https://github.com/rommapp/romm/pull/947](https://togithub.com/rommapp/romm/pull/947)
- Install redis instead of building in Dockerfile by
[@&#8203;gantoine](https://togithub.com/gantoine) in
[https://github.com/rommapp/romm/pull/945](https://togithub.com/rommapp/romm/pull/945)
- Fix section links and improve grammar/spelling in README.md by
[@&#8203;TylerVigario](https://togithub.com/TylerVigario) in
[https://github.com/rommapp/romm/pull/914](https://togithub.com/rommapp/romm/pull/914)
- Add trunk.io checks by
[@&#8203;gantoine](https://togithub.com/gantoine) in
[https://github.com/rommapp/romm/pull/868](https://togithub.com/rommapp/romm/pull/868)
- Add parallel-n64 to cores by
[@&#8203;gantoine](https://togithub.com/gantoine) in
[https://github.com/rommapp/romm/pull/923](https://togithub.com/rommapp/romm/pull/923)
- Use core icon when showing version by
[@&#8203;gantoine](https://togithub.com/gantoine) in
[https://github.com/rommapp/romm/pull/922](https://togithub.com/rommapp/romm/pull/922)
- Add interactive table of contents by
[@&#8203;Nicmorris1820](https://togithub.com/Nicmorris1820) in
[https://github.com/rommapp/romm/pull/924](https://togithub.com/rommapp/romm/pull/924)
- Added linuxserver/mariadb as alternative by
[@&#8203;need4swede](https://togithub.com/need4swede) in
[https://github.com/rommapp/romm/pull/926](https://togithub.com/rommapp/romm/pull/926)
- Added large carousel on screnshot click by
[@&#8203;zurdi15](https://togithub.com/zurdi15) in
[https://github.com/rommapp/romm/pull/932](https://togithub.com/rommapp/romm/pull/932)
- Resources structure migrated from
`resources/{platform_slug}/{rom_name}` to
`resources/roms/{platform_id}/{rom_id}`.
- Disabled zip compression on streaming multi-file download to increase
speed by [@&#8203;adamantike](https://togithub.com/adamantike) in
[https://github.com/rommapp/romm/pull/983](https://togithub.com/rommapp/romm/pull/983)
- Prevent mass-purging of roms during scan if filesystem is not
correctly mounted by [@&#8203;gantoine](https://togithub.com/gantoine)
in
[https://github.com/rommapp/romm/pull/987](https://togithub.com/rommapp/romm/pull/987)
- Fixed abort scan by [@&#8203;gantoine](https://togithub.com/gantoine)
in
[https://github.com/rommapp/romm/pull/1004](https://togithub.com/rommapp/romm/pull/1004)
- Added support for any kind of image extension on custom covers by
[@&#8203;gantoine](https://togithub.com/gantoine) in
[https://github.com/rommapp/romm/pull/1002](https://togithub.com/rommapp/romm/pull/1002)
-   Fixes and improvements everywhere

#### New Contributors

- [@&#8203;adamantike](https://togithub.com/adamantike) made their first
contribution in
[https://github.com/rommapp/romm/pull/947](https://togithub.com/rommapp/romm/pull/947)
- [@&#8203;TylerVigario](https://togithub.com/TylerVigario) made their
first contribution in
[https://github.com/rommapp/romm/pull/914](https://togithub.com/rommapp/romm/pull/914)
- [@&#8203;Nicmorris1820](https://togithub.com/Nicmorris1820) made their
first contribution in
[https://github.com/rommapp/romm/pull/924](https://togithub.com/rommapp/romm/pull/924)
- [@&#8203;need4swede](https://togithub.com/need4swede) made their first
contribution in
[https://github.com/rommapp/romm/pull/926](https://togithub.com/rommapp/romm/pull/926)
- [@&#8203;lepture](https://togithub.com/lepture) made their first
contribution in
[https://github.com/rommapp/romm/pull/931](https://togithub.com/rommapp/romm/pull/931)

**Full Changelog**:
rommapp/romm@3.2.0...3.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzQuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQzNC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantoine gantoine gantoine approved these changes

Assignees

@zurdi15 zurdi15

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zurdi15 @gantoine