Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly update state for cover deletion #1174

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

adamantike
Copy link
Collaborator

  • Initialize removeCover as false on each dialog render, so previous overrides don't affect the initial state.
  • Make both file upload and cover online search update removeCover to false.
  • Fix collection update to send remove_cover to the API.

Potential fix for #1169.

* Initialize `removeCover` as `false` on each dialog render, so previous
  overrides don't affect the initial state.
* Make both file upload and cover online search update `removeCover` to
  false.
* Fix collection update to send `remove_cover` to the API.

Potential fix for #1169.
@adamantike adamantike linked an issue Sep 5, 2024 that may be closed by this pull request
@adamantike adamantike merged commit b65345c into master Sep 6, 2024
7 checks passed
@adamantike adamantike deleted the fix/cover-update-and-delete branch September 6, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Custom Covers not saved
2 participants