Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROMM-1155] Patch zipfil + catch more 7zip errors #1156

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Sep 2, 2024

Recent versions of Microsoft Windows Explorer use Deflate64 compression when creating ZIP files larger than 2GB. These files are not well supported in open-source zip libraries due to it's closed-source nature, so we patch zipfile to support them.

Fixes #1155

Copy link

github-actions bot commented Sep 2, 2024

Test Results

81 tests  ±0   81 ✅ ±0   24s ⏱️ +3s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 00c8771. ± Comparison against base commit a11dc74.

@gantoine gantoine changed the title [ROMM0-1155] Patch zipfil + catch more 7zip errors [ROMM-1155] Patch zipfil + catch more 7zip errors Sep 2, 2024
@gantoine gantoine merged commit dc7719d into master Sep 2, 2024
8 checks passed
@gantoine gantoine deleted the romm-1155 branch September 2, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants