Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROMM-829] Status fields on rom user #1137

Merged
merged 14 commits into from
Sep 9, 2024
Merged

[ROMM-829] Status fields on rom user #1137

merged 14 commits into from
Sep 9, 2024

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Aug 29, 2024

This PR adds more fields onto the RomUser for setting game status (in progress, completed, 100%, etc) under the new Personal tab. Private and shared notes have been moved to the Personal tab as well.

Platforms and collections can be filtered by status (including backlogged and now playing). Hidden games will still be returned from the server but filtered out of the list.

TODO

  • Actually hide games from the UI that are marked as "hidden"

Closes #829

Screenshots

Screenshot 2024-08-29 at 7 10 13 PM Screenshot 2024-09-08 at 3 55 51 PM
Screenshot 2024-09-08 at 1 58 00 PM

Copy link

github-actions bot commented Aug 29, 2024

Test Results

81 tests   81 ✅  21s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 0b2a822.

♻️ This comment has been updated with latest results.

@gantoine gantoine requested review from adamantike and zurdi15 and removed request for adamantike September 8, 2024 20:08
@gantoine gantoine marked this pull request as ready for review September 8, 2024 20:11
backend/models/rom.py Outdated Show resolved Hide resolved
backend/endpoints/states.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@adamantike adamantike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gantoine gantoine merged commit fc6455e into master Sep 9, 2024
9 checks passed
@gantoine gantoine deleted the romm-829 branch September 9, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants