added update collection endpoint

backend/alembic/versions/0022_collections_.py

@@ -26,6 +26,7 @@ def upgrade() -> None:
         sa.Column("description", sa.Text(), nullable=True),
         sa.Column("path_cover_l", sa.String(length=1000), nullable=True),
         sa.Column("path_cover_s", sa.String(length=1000), nullable=True),
+        sa.Column("url_cover", sa.Text(), nullable=True),
         sa.Column("roms", sa.JSON(), nullable=False),
         sa.Column("user_id", sa.Integer(), nullable=False),
         sa.Column("is_public", sa.Boolean(), nullable=False),

backend/endpoints/collections.py

@@ -1,9 +1,12 @@
+import json
+
 from decorators.auth import protected_route
 from endpoints.responses import MessageResponse
 from endpoints.responses.collection import CollectionSchema
 from exceptions.endpoint_exceptions import (
     CollectionAlreadyExistsException,
     CollectionNotFoundInDatabaseException,
+    CollectionPermissionError,
 )
 from fastapi import APIRouter, Request
 from handler.database import db_collection_handler
@@ -75,7 +78,7 @@ def get_collection(request: Request, id: int) -> CollectionSchema:
 
 
 @protected_route(router.put, "/collections/{id}", ["collections.write"])
-async def update_collection(request: Request) -> MessageResponse:
+async def update_collection(request: Request, id: int) -> MessageResponse:
     """Update collection endpoint
 
     Args:
@@ -85,7 +88,33 @@ async def update_collection(request: Request) -> MessageResponse:
         MessageResponse: Standard message response
     """
 
-    return {"msg": "Enpoint not available yet"}
+    data = await request.form()
+    collection = db_collection_handler.get_collection(id)
+
+    if collection.user_id != request.user.id:
+        raise CollectionPermissionError(id)
+
+    if not collection:
+        raise CollectionNotFoundInDatabaseException(id)
+
+    roms = collection.roms  # Default to the roms list from the database
+
+    if "roms" in data:
+        try:
+            roms = json.loads(data.get("roms"))
+        except json.JSONDecodeError:
+            raise ValueError("Invalid JSON for roms field")
+
+    cleaned_data = {
+        "name": data.get("name", collection.name),
+        "description": data.get("description", collection.description),
+        "roms": roms,
+        "is_public": data.get("is_public", collection.is_public),
+        "user_id": request.user.id,
+    }
+
+    db_collection_handler.update_collection(id, cleaned_data)
+    return {"msg": "Collection updated  successfully!"}
 
 
 @protected_route(router.delete, "/collections/{id}", ["collections.write"])

backend/endpoints/responses/collection.py

@@ -9,6 +9,7 @@ class CollectionSchema(BaseModel):
     description: str
     path_cover_l: str | None
     path_cover_s: str | None
+    url_cover: str
     roms: set[int]
     rom_count: int
     user_id: int

backend/endpoints/responses/rom.py

@@ -126,12 +126,6 @@ def from_orm_with_request(cls, db_rom: Rom, request: Request) -> RomSchema:
 
         return rom
 
-    @classmethod
-    def from_orm_with_request_list(
-        cls, db_roms: list[Rom], request: Request
-    ) -> list[RomSchema]:
-        return [cls.from_orm_with_request(rom, request) for rom in db_roms]
-
     @computed_field  # type: ignore
     @property
     def sort_comparator(self) -> str:

backend/endpoints/rom.py

@@ -110,7 +110,7 @@ def get_roms(
         list[RomSchema]: List of roms stored in the database
     """
 
-    db_roms = db_rom_handler.get_roms(
+    roms = db_rom_handler.get_roms(
         platform_id=platform_id,
         collection_id=collection_id,
         search_term=search_term.lower(),
@@ -119,7 +119,7 @@ def get_roms(
         limit=limit,
     )
 
-    return RomSchema.from_orm_with_request_list(db_roms, request)
+    return [RomSchema.from_orm_with_request(rom, request) for rom in roms]
 
 
 @protected_route(
@@ -370,7 +370,7 @@ async def update_rom(
         else:
             cleaned_data["url_cover"] = data.get("url_cover", rom.url_cover)
             path_cover_s, path_cover_l = fs_resource_handler.get_rom_cover(
-                overwrite=True,
+                overwrite=cleaned_data["url_cover"] != rom.url_cover,
                 rom=rom,
                 url_cover=cleaned_data.get("url_cover", ""),
             )

backend/exceptions/endpoint_exceptions.py

@@ -29,9 +29,18 @@ def __init__(self, id):
         self.message = f"Collection with id '{id}' not found"
         super().__init__(self.message)
         log.critical(self.message)
-        raise HTTPException(
-            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, detail=self.message
-        )
+        raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=self.message)
+
+    def __repr__(self) -> str:
+        return self.message
+
+
+class CollectionPermissionError(Exception):
+    def __init__(self, id):
+        self.message = f"Permission denied for collection with id '{id}'"
+        super().__init__(self.message)
+        log.critical(self.message)
+        raise HTTPException(status_code=status.HTTP_403_FORBIDDEN, detail=self.message)
 
     def __repr__(self) -> str:
         return self.message

backend/handler/database/collections_handler.py

@@ -1,6 +1,6 @@
 from decorators.database import begin_session
 from models.collection import Collection
-from sqlalchemy import Select, and_, delete, or_, select
+from sqlalchemy import Select, delete, select, update
 from sqlalchemy.orm import Session
 
 from .base_handler import DBBaseHandler
@@ -41,6 +41,17 @@ def get_collections(
             .all()
         )
 
+    @begin_session
+    def update_collection(
+        self, id: int, data: dict, session: Session = None
+    ) -> Collection:
+        return session.execute(
+            update(Collection)
+            .where(Collection.id == id)
+            .values(**data)
+            .execution_options(synchronize_session="evaluate")
+        )
+
     @begin_session
     def delete_collection(self, id: int, session: Session = None) -> int:
         return session.execute(

backend/models/collection.py

@@ -1,5 +1,7 @@
 from __future__ import annotations
 
+from functools import cached_property
+
 from models.base import BaseModel
 from models.user import User
 from sqlalchemy import JSON, ForeignKey, String, Text
@@ -17,6 +19,10 @@ class Collection(BaseModel):
     path_cover_l: Mapped[str | None] = mapped_column(Text, default="")
     path_cover_s: Mapped[str | None] = mapped_column(Text, default="")
 
+    url_cover: Mapped[str | None] = mapped_column(
+        Text, default="", doc="URL to cover image stored in IGDB"
+    )
+
     roms: Mapped[set[int]] = mapped_column(
         JSON, default=[], doc="Rom id's that belong to this collection"
     )
@@ -33,5 +39,9 @@ def user__username(self) -> str:
     def rom_count(self):
         return len(self.roms)
 
+    @cached_property
+    def has_cover(self) -> bool:
+        return bool(self.path_cover_s or self.path_cover_l)
+
     def __repr__(self) -> str:
         return self.name

frontend/src/components/common/Collection/Dialog/EditCollection.vue

@@ -43,7 +43,7 @@ function previewImage(event: Event) {
 }
 
 async function removeArtwork() {
-  imagePreviewUrl.value = `/assets/default/cover/big_${theme.global.name.value}_missing_cover.png`;
+  imagePreviewUrl.value = `/assets/default/cover/big_${theme.global.name.value}_collection.png`;
   removeCover.value = true;
 }