Skip to content

Commit

Permalink
Forbid using window properties as global variables (facebook#1840)
Browse files Browse the repository at this point in the history
* Forbid using window properties as global variables

* Change globals list to match Standard.

* Fix globals
  • Loading branch information
sidoshi authored and romaindso committed Jul 10, 2017
1 parent 9c7e34f commit aa06492
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 5 deletions.
8 changes: 7 additions & 1 deletion packages/eslint-config-react-app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,19 @@ module.exports = {
plugins: ['import', 'flowtype', 'jsx-a11y', 'react'],

env: {
browser: true,
commonjs: true,
es6: true,
jest: true,
node: true,
},

globals: {
document: true,
window: true,
console: true,
navigator: true
},

parserOptions: {
ecmaVersion: 6,
sourceType: 'module',
Expand Down
4 changes: 2 additions & 2 deletions packages/react-scripts/fixtures/kitchensink/src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class BuiltEmitter extends Component {
}

handleReady() {
document.dispatchEvent(new Event('ReactFeatureDidMount'));
document.dispatchEvent(new window.Event('ReactFeatureDidMount'));
}

render() {
Expand Down Expand Up @@ -54,7 +54,7 @@ class App extends Component {
}

componentDidMount() {
const feature = location.hash.slice(1);
const feature = window.location.hash.slice(1);
switch (feature) {
case 'array-destructuring':
import(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import React from 'react';
import aFileWithoutExt from './assets/aFileWithoutExt';

const text = aFileWithoutExt.includes('base64')
? atob(aFileWithoutExt.split('base64,')[1]).trim()
? window.atob(aFileWithoutExt.split('base64,')[1]).trim()
: aFileWithoutExt;

export default () => (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import React from 'react';
import aFileWithExtUnknown from './assets/aFileWithExt.unknown';

const text = aFileWithExtUnknown.includes('base64')
? atob(aFileWithExtUnknown.split('base64,')[1]).trim()
? window.atob(aFileWithExtUnknown.split('base64,')[1]).trim()
: aFileWithExtUnknown;

export default () => (
Expand Down

0 comments on commit aa06492

Please sign in to comment.