Put console.stack() behind a react vendor prefix (facebook#2164)

Matches what we did in facebook/react#9679
romaindso · Jul 10, 2017 · 87aa281 · 87aa281
1 parent a602fe4
commit 87aa281
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/packages/react-error-overlay/src/effects/proxyConsole.js b/packages/react-error-overlay/src/effects/proxyConsole.js
@@ -3,24 +3,31 @@
 type ReactFrame = {
   fileName: string | null,
   lineNumber: number | null,
-  functionName: string | null,
+  name: string | null,
 };
 const reactFrameStack: Array<ReactFrame[]> = [];
 
 export type { ReactFrame };
 
+// This is a stripped down barebones version of this proposal:
+// https://gist.github.com/sebmarkbage/bdefa100f19345229d526d0fdd22830f
+// We're implementing just enough to get the invalid element type warnings
+// to display the component stack in React 15.6+:
+// https://github.com/facebook/react/pull/9679
+/// TODO: a more comprehensive implementation.
+
 const registerReactStack = () => {
   // $FlowFixMe
-  console.stack = frames => reactFrameStack.push(frames);
+  console.reactStack = frames => reactFrameStack.push(frames);
   // $FlowFixMe
-  console.stackEnd = frames => reactFrameStack.pop();
+  console.reactStackEnd = frames => reactFrameStack.pop();
 };
 
 const unregisterReactStack = () => {
   // $FlowFixMe
-  console.stack = undefined;
+  console.reactStack = undefined;
   // $FlowFixMe
-  console.stackEnd = undefined;
+  console.reactStackEnd = undefined;
 };
 
 type ConsoleProxyCallback = (message: string, frames: ReactFrame[]) => void;

diff --git a/packages/react-error-overlay/src/utils/warnings.js b/packages/react-error-overlay/src/utils/warnings.js
@@ -33,9 +33,9 @@ function massage(
     lastFilename = fileName;
     lastLineNumber = lineNumber;
 
-    let { functionName } = frames[index];
-    functionName = functionName || '(anonymous function)';
-    stack += `in ${functionName} (at ${fileName}:${lineNumber})\n`;
+    let { name } = frames[index];
+    name = name || '(anonymous function)';
+    stack += `in ${name} (at ${fileName}:${lineNumber})\n`;
   }
 
   return { message, stack };