Ensure address is private (facebook#2297)

* Ensure address is private Resolves facebook#2296 * adjust rule * Update WebpackDevServerUtils.js
romaindso · Jul 10, 2017 · 59ffa84 · 59ffa84
1 parent 279e8df
commit 59ffa84
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/packages/react-dev-utils/WebpackDevServerUtils.js b/packages/react-dev-utils/WebpackDevServerUtils.js
@@ -52,9 +52,22 @@ function prepareUrls(protocol, host, port) {
   if (isUnspecifiedHost) {
     prettyHost = 'localhost';
     try {
+      // This can only return an IPv4 address
       lanUrlForConfig = address.ip();
       if (lanUrlForConfig) {
-        lanUrlForTerminal = prettyPrintUrl(lanUrlForConfig);
+        // Check if the address is a private ip
+        // https://en.wikipedia.org/wiki/Private_network#Private_IPv4_address_spaces
+        if (
+          /^10[.]|^172[.](1[6-9]|2[0-9]|3[0-1])[.]|^192[.]168[.]/.test(
+            lanUrlForConfig
+          )
+        ) {
+          // Address is private, format it for later use
+          lanUrlForTerminal = prettyPrintUrl(lanUrlForConfig);
+        } else {
+          // Address is not private, so we will discard it
+          lanUrlForConfig = undefined;
+        }
       }
     } catch (_e) {
       // ignored