Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Fix ignore global #86

Merged
merged 2 commits into from
Aug 31, 2016
Merged

Fix ignore global #86

merged 2 commits into from
Aug 31, 2016

Conversation

dmitrage
Copy link
Contributor

No description provided.

@TrySound
Copy link
Member

@dmitrage Hi! Thanks for PR. Can you provide test case please?

@dmitrage
Copy link
Contributor Author

@TrySound Hi! Instead I've added comment with "require" to the existing one that was actually skipped because of the firstpass check.

Or should I create different cases for the firstpass regexp, Identifier and ThisExpression in this PR?

@TrySound
Copy link
Member

@dmitrage Better different. Caz it's not actually ignore-global

@TrySound
Copy link
Member

But you may combine them in one.

@dmitrage
Copy link
Contributor Author

@TrySound I've updated test case to cover ignoreGlobal feature:

  • try to skip module by firstpass, excluding "global" pattern from regexp
  • do not mark "uses.global" when "global" identifier is found (implemented in this PR)
  • do not mark "uses.global" when global "this" is found

Is that what you meant?

@Rich-Harris Rich-Harris merged commit 7e557a7 into rollup:master Aug 31, 2016
@Rich-Harris
Copy link
Contributor

Thanks! Sorry for the slow turnaround, released as 4.0.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants