Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alias,auto-install,buble,commonjs,data-uri,dsv,dynamic-import-vars,eslint,graphql,html,image): types should come first in exports #1403

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

benmccann
Copy link
Contributor

Rollup Plugin Name: {name}

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

types must come first. See the TypeScript docs here: https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing

@shellscape
Copy link
Collaborator

Thanks for this. To publish all of the plugins in this PR with CI, the names must be included in the commit scope, comma separated without spaces. e.g.

fix(alias,auto-install): yadda

It's gonna be a long commit message, but that's how it currently runs.

…s,eslint,graphql,html,image): types should come first in exports
@benmccann benmccann changed the title fix: types should come first in exports fix(alias,auto-install,buble,commonjs,data-uri,dsv,dynamic-import-vars,eslint,graphql,html,image): types should come first in exports Jan 15, 2023
@benmccann
Copy link
Contributor Author

Ok, thanks. I've updated the commit message

Copy link
Collaborator

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this one without additional maintainer review as the change is straightforward.

thanks!

@shellscape shellscape merged commit be71165 into rollup:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants