Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

feat: Add expected valid app hash #10

Merged

Conversation

Manav-Aggarwal
Copy link
Member

@Manav-Aggarwal Manav-Aggarwal commented Dec 2, 2022

Description

We'd like to add the expected valid app hash in Fraud Proof struct so that during verification, a light client knows what is the valid app hash that it should expect.

Closes: #11


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@Manav-Aggarwal Manav-Aggarwal changed the title Add expected valid app hash feat: Add expected valid app hash Dec 2, 2022
@Manav-Aggarwal Manav-Aggarwal linked an issue Dec 2, 2022 that may be closed by this pull request
@Manav-Aggarwal Manav-Aggarwal self-assigned this Dec 2, 2022
@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review December 2, 2022 21:53
Copy link
Member

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

baseapp/abci.go Show resolved Hide resolved
@Manav-Aggarwal Manav-Aggarwal merged commit 77071e8 into manav/fraudproof_iavl_prototype Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add expected valid app hash to Fraud Proof
2 participants