Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Issue 226: Update rollbar.js code snippet #228

Conversation

ArturMoczulski
Copy link
Contributor

This PR introduces automatic updates for rollbar.snippet.js through composer and rollbar/rollbar.js repository.

@ArturMoczulski
Copy link
Contributor Author

Ready for review

@rokob
Copy link
Contributor

rokob commented Jul 18, 2017

I don't think we want to always be pulling down master from rollbar.js, I think we want to have stable versions for each rollbar-php release

@ArturMoczulski
Copy link
Contributor Author

@rokob Okay, I locked master at rollbar.js 2.1.0 . This is ready to merge if it looks good to you.

Copy link
Contributor

@coryvirok coryvirok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Is it possible to pin the rollbar.js dependency at a minor version number so installs will get patch updates?

@cordoval
Copy link
Contributor

can we make this somehow suggested dep? if we don't use this why would we require it?
I am plugging frontend with frontend stuff and backend with backend stuff separately, why mixing them? Or am i missing something, sorry.

@ArturMoczulski
Copy link
Contributor Author

ArturMoczulski commented Jul 21, 2017

@cordoval is making a good point imho. unfortunately, if we move rollbar.js to suggestions we can't enforce the version at all other than just provide written instructions as of to what version is the best. I think it would be best to keep rollbar.js as a suggestion and let it be required separately in the appropriate version (with a recommendation in composer suggest description). @coryvirok what do you think

@ArturMoczulski
Copy link
Contributor Author

@cordoval we are going to go ahead with rollbar.js as a requirement, but might change it to being a suggested package at a later date.

@ArturMoczulski ArturMoczulski merged commit a6384dd into rollbar:master Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants