-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Issue 226: Update rollbar.js code snippet #228
Github Issue 226: Update rollbar.js code snippet #228
Conversation
Ready for review |
I don't think we want to always be pulling down master from rollbar.js, I think we want to have stable versions for each rollbar-php release |
@rokob Okay, I locked master at rollbar.js 2.1.0 . This is ready to merge if it looks good to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Is it possible to pin the rollbar.js dependency at a minor version number so installs will get patch updates?
can we make this somehow suggested dep? if we don't use this why would we require it? |
@cordoval is making a good point imho. unfortunately, if we move rollbar.js to suggestions we can't enforce the version at all other than just provide written instructions as of to what version is the best. I think it would be best to keep rollbar.js as a suggestion and let it be required separately in the appropriate version (with a recommendation in composer suggest description). @coryvirok what do you think |
@cordoval we are going to go ahead with rollbar.js as a requirement, but might change it to being a suggested package at a later date. |
This PR introduces automatic updates for rollbar.snippet.js through composer and rollbar/rollbar.js repository.