Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Docker image #43

Merged
merged 1 commit into from
May 23, 2021
Merged

Build Docker image #43

merged 1 commit into from
May 23, 2021

Conversation

edumco
Copy link
Contributor

@edumco edumco commented May 1, 2021

This adds another parallel job to github actions to build the docker image

In the future is possible to use this docker image to publish to a container registry or simply to test if it works correctly

@jonasbn jonasbn self-requested a review May 4, 2021 18:03
@jonasbn
Copy link
Collaborator

jonasbn commented May 5, 2021

Hi @edumco

This looks promising and the idea of doing CI of the Docker build process sounds very interesting. As I understand the image is discarded post build - for now?

@edumco
Copy link
Contributor Author

edumco commented May 8, 2021

@jonasbn Yes, for now it wont publish. I'm taking baby steps

@jonasbn
Copy link
Collaborator

jonasbn commented May 20, 2021

Hi @edumco

This is a paving the way I want to go BUT the reason I am reluctant is the publishing part.

This most likely require some sort of authentication/authorization, possibly based on a GITHUB_TOKEN. Since this it not my repository, the is not an available option as such.

Any ideas or suggestions are most welcome.

Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though

@jonasbn jonasbn self-assigned this May 20, 2021
@edumco
Copy link
Contributor Author

edumco commented May 23, 2021

Hi @jonasbn. I agree with you. But this pull request only validates the docker building process.

The Docker release must be done in a future pull request.

In a first moment I though just to make possible download the image as an build artifact to run tests in the pipeline and in a second moment make the tested images available as public image with the latest tag on github

@jonasbn jonasbn merged commit 6a3a2be into rojopolis:master May 23, 2021
@jonasbn
Copy link
Collaborator

jonasbn commented May 23, 2021

HI @edumco

Then lets start here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants