Skip to content

Commit

Permalink
Implemented hack to reinstate disappearing aspell, by reinstall in th…
Browse files Browse the repository at this point in the history
…e wrong stage :-/ (#56)
  • Loading branch information
jonasbn committed Aug 15, 2021
1 parent 8d01ffe commit 5330262
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/spelling_action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
steps:
# The checkout step
- uses: actions/checkout@master
- uses: rojopolis/spellcheck-github-actions@0.15.0
- uses: rojopolis/spellcheck-github-actions@0.14.0
name: Spellcheck
with:
source_files: README.md CHANGELOG.md
Expand Down
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# Change Log for spellcheck-github-actions

## 0.15.0 2021-08-13 maintenance release, update not required
## 0.16.0 2021-08-15 bug fix release, update recommended

Experienced an issue with the new multi-stage Docker build, where `aspell` _disappears_.

This release implements a _hack_ to make use that it is present, by reinstalling it :-/

## 0.15.0 2021-08-15 maintenance release, update not required

Issue [#53](https://github.com/rojopolis/spellcheck-github-actions/issues/53) describes an issue with ignoring Markdown regions with code fences. This was an issue in `pyspelling`, which is the core component in this action. Luckily @facelessuser, the maintainer of `pyspelling` was to [fix it](https://github.com/facelessuser/pyspelling/pull/144). So the requirement for `pyspelling` was bumped from 2.6.1 to 2.7.3

Expand Down
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ RUN apt-get update && apt-get install -y \
FROM spellcheck-builder as spellcheck

RUN apt-get update && apt-get install -y \
aspell \
# split arg SPELLCHECK_LANGS to space separated, and prepend each with 'aspell-'
$(echo "$SPELLCHECK_LANGS" | sed 's/,/ /g' | xargs printf -- 'aspell-%s\n') \
&& rm -rf /var/lib/apt/lists/*
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
steps:
# The checkout step
- uses: actions/checkout@master
- uses: rojopolis/spellcheck-github-actions@0.15.0
- uses: rojopolis/spellcheck-github-actions@0.16.0
name: Spellcheck
```
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
steps:
# The checkout step
- uses: actions/checkout@master
- uses: rojopolis/spellcheck-github-actions@0.15.0
- uses: rojopolis/spellcheck-github-actions@0.16.0
name: Spellcheck
with:
source_files: README.md CHANGELOG.md notes/Notes.md
Expand Down Expand Up @@ -150,7 +150,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: rojopolis/spellcheck-github-actions@0.15.0
- uses: rojopolis/spellcheck-github-actions@0.16.0
name: Spellcheck
with:
config_path: config/.spellcheck.yml # put path to configuration file here
Expand Down Expand Up @@ -399,7 +399,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: rojopolis/spellcheck-github-actions@0.15.0
- uses: rojopolis/spellcheck-github-actions@0.16.0
name: Spellcheck
```

Expand Down

0 comments on commit 5330262

Please sign in to comment.