Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accepting different token types #60

Merged
merged 6 commits into from
Aug 3, 2024
Merged

Conversation

Midnightific
Copy link
Contributor

@Midnightific Midnightific commented Aug 1, 2024

Fixes accepting different token types

If no one’s got objections I’ve started writing up a draft of a GitHub action for rokit so I’d love to be the one to publish it if that’s okay.

Removing regex was @Dekkonot's suggestion so if you can somehow add him as a coauthor that'd be great!

@Midnightific
Copy link
Contributor Author

Midnightific commented Aug 1, 2024

Sorry just realised I left the test in there, if someone could remove that then that’d be great 😅(as I’ve gotten off for the night)

Midnightific and others added 3 commits August 2, 2024 15:07
I'm still new to rust and I'm guessing this will have some overhead cloning it so just lmk with any changes
Co-authored-by: Micah <git@dekkonot.com>
@Paracosm-Daemon
Copy link

Paracosm-Daemon commented Aug 3, 2024

Glad to see this. I switched to Rokit recently for a few things I'm working on, and the token auth issue completely severed my ability to publish packages via GitHub Actions.

If no one’s got objections I’ve started writing up a draft of a GitHub action for rokit so I’d love to be the one to publish it if that’s okay.

Sidenote- this was already made, but it's currently nonfunctional due to the aforementioned issue.

@Midnightific
Copy link
Contributor Author

Yeah I didn't know that until yesterday but as long as someone's done it then that's fantastic! 😄

Copy link
Collaborator

@filiptibell filiptibell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and for fixing this! It seems like tracking down an official source on exactly what formats and prefixes the github tokens can have is challenging... so a solution like this one, matching against any github-like token, probably fits Rokit best.
I dont imagine it will cause any issues since the rokit authenticate github command also checks that the token is valid using the API.

@filiptibell filiptibell merged commit 9d7a1ff into rojo-rbx:main Aug 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants