Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tracing more user-friendly #46

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Make tracing more user-friendly #46

merged 6 commits into from
Jul 16, 2024

Conversation

filiptibell
Copy link
Collaborator

@filiptibell filiptibell commented Jul 16, 2024

Summary

This PR makes a couple changes to tracing in Rokit:

  • Adds a new --verbose flag to the CLI, making debugging Rokits behavior much more straightforward for a normal user. This flag may be specified twice for extra verbose logging with even more information.
  • Removes the directly user-facing warning when a direct tool artifact match is not found, in favor of tracing messages that can be enabled with the new --verbose flag.
  • Fixes the tracing level of some internal mechanisms such as executable parsing being set too high.

Implementation note

The new --verbose flag is unfortunately order-dependent, meaning that this works:

  • rokit --verbose install

... while this does not:

  • rokit install --verbose

I didn't find any way around this using clap, or at least when using derive macros. It shouldn't be too much of an issue in practice but it is something to keep in mind.

@filiptibell filiptibell merged commit ca201e4 into main Jul 16, 2024
10 checks passed
@filiptibell filiptibell deleted the tracing-improvements branch July 16, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant