Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement improved compat sorting when multiple artifacts are compatible #45

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

filiptibell
Copy link
Collaborator

This PR implements a secondary artifact sorting algorithm, that applies when all other sorting for OS and architecture compatibility are equal. Notably, installing selene, which has several tool artifacts in each release, will now work properly because the additional sorting algorithm allows us to accept more than a single compatible artifact per release, and choose the best.

System compatibility (OS, arch) still takes precedence over all other sorting and as such current compatibility with already working tools will not be affected.

Fixes #41

Copy link
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When installing Selene, I still get a warning that says:

Failed to find a fully compatible artifact for kampfkarren/selene!
This seems to have been caused by selene not specifying an architecture in any of its artifacts.

I feel as though this is not what we should say when searching for a fallback (and in fact that process should probably be invisible to users outside of a quick message about what artifact is being used).

@filiptibell
Copy link
Collaborator Author

I feel as though this is not what we should say when searching for a fallback (and in fact that process should probably be invisible to users outside of a quick message about what artifact is being used)

That makes sense to me - I'll improve on this and tracing in general in another PR after this one 👍

@filiptibell filiptibell merged commit a6b84cc into main Jul 16, 2024
10 checks passed
@filiptibell filiptibell deleted the improve-artifact-compat-some-more branch July 16, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rokit fails to find artifact for selene on at least windows
2 participants