Fix artifact matching being sensitive to extensions, add tests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version
0.1.2of Rokit, more specifically commit f7f928f, Rokit started using a more strict OS and architecture detection algorithm. This passed all tests, but unfortunately, our tests did not catch a fatal flaw: OS and architecture detection was now sensitive to file extensions being included in the search string. Artifact names such as these:toolname-win.ziptoolname-win64.zipno longer downloaded correctly because
win.zipwas being interpreted as one "word" and this word was not in the list of words matching the Windows platform. This PR fixes the issue by stripping file extensions before parsing, and also adds extra tests to theArtifactFormatenum and its parsing since it underwent some larger changes.