Improve artifact compatibility by adding a fallback mechanism #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptibell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a simple fallback mechanism for when tools do not specify architectures in their release files:
tool-name-windows.zipother-tool_macos.tar.gzArchis no longer mandatory in aDescriptorsince this seems to be a common pattern, and Rokit should not assume any architecture as "default" since arm macs and pcs are now much more common. We will implement improved fallbacks in the future as part of #4, but for now this PR solves a very real issue and does so in a user-friendly way while also spreading awareness.Fixes #37