-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use history recording and don't do anything permanent #915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have concerns about memory usage if we make this change, since connections will remain active on Instances now. I know there's not much we can do about it, but I'm still unhappy.
Otherwise, would prefer we not use Remove but looks good to me.
Sums up a lot of Rojo work, doesn't it 😭 |
Does the problem in the linked issue only occur for changed class names? We destroy instances for normal removals, too |
Good catch, Ken. Updated all uses of |
Adopts the latest ChangeHistoryService APIs. Our Undo/Redo notification warnings (to prevent accidentally undoing a Rojo patch) still work fine with this new API.
Avoids the permanent Destroy action, uses Remove instead. This closes #914.