Add protection against syncing non place projects #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, easy. My only suggestion is to more explicitly tell the user what they need to do to fix this, because they might not know what a "non-place project" is or what they should be looking for. Change the message to something like: Maybe even show them what the project file should look like? |
|
Good change. We can link to the project format documentation. |
kennethloeffler
approved these changes
Jun 2, 2023
boatbomber
added
type: enhancement
Dekkonot
approved these changes
Jun 30, 2023
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
Closes rojo-rbx#113. Does what it says on the tin. When you try to sync a non-place project, it gives a clear message instead of crashing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113.
Does what it says on the tin. When you try to sync a non-place project, it gives a clear message instead of crashing.