Add Rails 6 memory allocations to default log #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@J-Swift could you rebase this on master so the tests run on the latest CI? Looks like a great change. |
J-Swift
force-pushed
the
feature/add-allocations-to-logs
branch
from
881755b
to
dd9bfa9
Compare
|
@iloveitaly rebased |
|
@J-Swift I'd love to get this in, but the tests are failing. Mind taking another look? |
|
No offense, but I've moved on at this point. The tests were passing before, so I'm not sure what to say. |
|
@J-Swift / @iloveitaly -- I got y'all -- see #355 |
|
Awesome! Closing this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 6 provides allocations to event subscribers now, so it would be nice to include these in the default stats when available