accommodating default rack-cache settings

[jjb]

I think starting in rails 4, rack-cache can be configured with a simple boolean like so:

config.action_dispatch.rack_cache = true

And rails will use defaults: https://github.com/rails/rails/blob/master/railties/lib/rails/application/default_middleware_stack.rb#L83-L91

lograge doesn't accommodate this scenario, and ends up trying to access []= on true https://github.com/roidrage/lograge/blob/master/lib/lograge.rb#L103

since the default verbosity is false anyway, this scenario can be accommodated by simply doing nothing if app.config.action_dispatch.rack_cache == true

let me know what you think and i can put together a pull request

[roidrage]

Interesting, the rack_cache setting would then silence the logs or disable rack-cache altogether?

[jjb]

Not sure I understand your question. What happens is if one uses config.action_dispatch.rack_cache = true in one's config, then lograge blows up as it tries to treat that boolean as a hash. The solution in my project was to use the full hash in the config

config.action_dispatch.rack_cache =
  { metastore: "rails:/", entitystore: "rails:/", verbose: false }

[roidrage]

Ah, now I understand, sorry.

This would happen when someone disable rack_cache then. I can add a workaround for that.