Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make texlive's path to be unrelated to CPU architectures #482

Merged
merged 6 commits into from
Jun 10, 2022
Merged

Make texlive's path to be unrelated to CPU architectures #482

merged 6 commits into from
Jun 10, 2022

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Jun 8, 2022

  • Remove (hard-coded) ARCH in PATH

Fixes #478

@benz0li
Fix PATH for texlive
daa84ae 
- Remove (hard-coded) ARCH in PATH
@benz0li
Copy link
Contributor Author

benz0li commented Jun 8, 2022 •
edited
Loading

@eitsupi The symbolic link is created before any tlmgr action is executed. This is required, because installing context runs mtxrun --generate post-installation.
ℹ️ Without the symbolic link, mtxrun is not found / not in PATH – and the installation fails.

@benz0li
Copy link
Contributor Author

benz0li commented Jun 8, 2022

rocker-versioned2/scripts/install_texlive.sh

Line 31 in ae74156

export PATH="${PATH}:/usr/local/texlive/bin/${ARCH}-linux/"

might not be required, because ENV is set beforehand in the Dockerfile.

eitsupi
eitsupi requested changes Jun 8, 2022
View reviewed changes
Copy link
Member

@eitsupi eitsupi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a look at this.
However, there may be no need to update these Dockerfiles at this stage as these can only be built on linux/arm64 linux/amd64.

I also wonder if adding the symbolic link to a location already added to the PATH would eliminate the need to update the PATH.

dockerfiles/verse_4.2.0.Dockerfile Show resolved Hide resolved
eitsupi
eitsupi reviewed Jun 9, 2022
View reviewed changes
scripts/install_texlive.sh Outdated Show resolved Hide resolved
eitsupi
eitsupi requested changes Jun 9, 2022
View reviewed changes
Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the build test failed.
And, suggestion to avoid linter complaining.

scripts/install_texlive.sh Outdated Show resolved Hide resolved
@benz0li @eitsupi
Update scripts/install_texlive.sh
717ea2a 
Make linter happy

Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com>
@benz0li
Copy link
Contributor Author

benz0li commented Jun 9, 2022

@eitsupi Thanks for reviewing.

eitsupi
eitsupi approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working for this!

@eitsupi eitsupi changed the title Fix PATH for texlive Make texlive's path to be unrelated to CPU architectures Jun 10, 2022
@eitsupi eitsupi merged commit a6c18b3 into rocker-org:master Jun 10, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hard-coded arch for texlive in PATH
2 participants
@benz0li @eitsupi