Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements #64

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

CristiFati
Copy link

@CristiFati CristiFati commented May 28, 2021

  • 7981f16:
    • If a model with an unsupported platform is encountered, an error test is displayed but the conversion is still attempted with no module loaded. Didn't actually try (it should fail), but it looks incorrect
  • 39d26ae:
    • model_path is a wrong (and misleading) name
    • model_file_path field contains the model file name (relative to the .yml file). But when the script is invoked like python rknn_convert.py path/to/model_config.yml ..., path/to is being prepended to the relative one, resulting in an invalid path
  • 45ffba3:
    • A bit of refactoring around reading config
    • Small variable renames and text changes
  • 3c8c1cf:
    • Extract common code
    • Moving around, so that similar platforms come consecutively
  • d929cea:
    • Field name:
      • Not consistent with the others (- instead of _)
      • Not very suggestive (although that comes from the rknn package)
    • Field value:
      • Is a list of lists of ints. No reason to store it as a string then parse it
  • 3aa5419 + a345d99:
    • Properly parse and handle script arguments

@CristiFati CristiFati changed the title Skip model configs having unknown platform Fixes and improvements May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant