Implement frame poisoning #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavv
force-pushed
the
poison
branch
2 times, most recently
from
9b445cd
to
7262abc
Compare
dshil
requested changes
Jan 10, 2019
dshil
requested changes
Jan 12, 2019
dshil
approved these changes
Jan 13, 2019
dshil
requested changes
Jan 13, 2019
dshil
approved these changes
Jan 13, 2019
|
LGTM, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the --poisoning flag. When enabled, every component that creates new frames begins to "poison" them (just fill with ones) before passing further to the pipeline. This simple technique helps to detect components that leaves some frame samples uninitialized, because now these samples become more audible.
@dshil could you please review this?