Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to diagnostic parser overheating error and Update embObjBattery #953

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Mar 21, 2024

Changes in this PR:

  • Add to diagnostic parser overheating error
  • Update embObjBattery
  • Re-elaborate status bat-bms using uint16_t as datatype and using string_view instead of string for status messages
  • Update bat reading values adding total absorbed current in BAT and adjusting limits for BAT SoC calculation
  • Fix datatype in diagnostic to be aligned by raw value datatype Set value of battery charge to NaN if equal to zero
  • Update MINIMUM_REQUIRED_icub_firmware_shared_VERSION to 1.38.2

Related to:

device

Re-elaborate status bat-bms using uint16_t as datatype
and using string_view instead of string for status messages
Update bat reading values adding total abosorbed current in BAT
and adjusting limits for BAT SoC calculation
Fix datatype in diagnostic to be aligned by raw value datatype
Set value of battery charge to NaN if equal to zero
Update MINIMUM_REQUIRED_icub_firmware_shared_VERSION to 1.38.2
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🚀
This code has been tested on the robot see here

@pattacini pattacini marked this pull request as ready for review March 26, 2024 15:33
@pattacini
Copy link
Member

robotology/icub-firmware-shared#95 has been merged.
Put this PR in ready for review to enable CI.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed ✅
Merging.

@pattacini pattacini merged commit 4a0e4a4 into robotology:devel Mar 26, 2024
4 of 8 checks passed
@MSECode MSECode deleted the feature/batUpdate branch June 13, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants