Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialPort_nws_yarp device to run faceExpressions on iCub* #883

Merged
merged 1 commit into from
May 31, 2023

Conversation

martinaxgloria
Copy link
Contributor

I removed the faceExpressionsSim.xml.template since it's no more used and I added a new file called serialPortFaceExpressions.xml. The reason is that the device serialPort_nws_yarp could not be run with yarpdev which is deprecated (cc @randaz81) but it should be launched with the yarprobotinterface using the new xml file as config parameter.

This new configuration was tested on iCubGenova11 and it works properly, also in changing the face expressions through the rpc protocol.

@CLAassistant
Copy link

CLAassistant commented May 30, 2023

CLA assistant check
All committers have signed the CLA.

@randaz81
Copy link
Member

For extra clarity: yarpdev is not currently deprecated, but it is unmaintained and it might be deprecated in the near future. Some old devices will still work, but new nws devices are developed and tested to be used only with yarprobotinterface.
Besides having a different plugin loader, yarprobotinterface supports attach operations between multiple devices, which is a fundamental feature for ROS/ROS2 compatibility.

@pattacini pattacini merged commit 5e3d12c into robotology:master May 31, 2023
@martinaxgloria martinaxgloria deleted the fix/serialPort branch June 1, 2023 06:40
valegagge pushed a commit to valegagge/icub-main that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants