Fix two bugs in embObjMultipleFTsensors #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when no measure has been read Before this commit, embObjMultipleFTsensors::get<Type>Status returned MAS_OK even if no measure has been read from the sensor, so it returns MAS_OK and then returns an invalid measure. After this commit, before a measure has been readed the status returned is MAS_WAITING_FOR_FIRST_READ.
…ors() Due to how the embObjMultipleFTsensors::getNrOfTemperatureSensors() function was implemented and how the internal buffers of embObjMultipleFTsensors were initialized, the embObjMultipleFTsensors::getNrOfTemperatureSensors() method was return 0 until an actual temperature measure was reported. This commit fixes this by using to compute getNrOfTemperatureSensors a buffer that has the correct shape even if no temperature measure has been read.
pattacini
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the two bugs:
Fix implementation of embObjMultipleFTsensors::getStatus methods when no measure has been read
Before this commit, embObjMultipleFTsensors::getStatus returned MAS_OK even if no measure has been read from the sensor, so it returns MAS_OK and then returns an invalid measure. After this commit, before a measure has been readed the status returned is MAS_WAITING_FOR_FIRST_READ.
Fix implementation of embObjMultipleFTsensors::getNrOfTemperatureSensors()
Due to how the embObjMultipleFTsensors::getNrOfTemperatureSensors() function was implemented and how the internal buffers of embObjMultipleFTsensors were initialized, the embObjMultipleFTsensors::getNrOfTemperatureSensors() method was return 0 until an actual temperature measure was reported. This commit fixes this by using to compute getNrOfTemperatureSensors a buffer that has the correct shape even if no temperature measure has been read.