Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct enabled property in helmfile list #1921

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Conversation

hikhvar
Copy link
Contributor

@hikhvar hikhvar commented Jul 19, 2021

Use the value of the condition field instead of the installed field of a release in the enabled column of helmfile list.
The value of the installed field is shown in a new installed column.

Fixes #1920

New output of helmfile list:

NAME      	NAMESPACE	ENABLED	INSTALLED	LABELS                    	CHART   	VERSION
myrelease1	         	true   	false    	common:label,id:myrelease1	mychart1	       
myrelease2	         	false  	true     	common:label              	mychart1	       
myrelease3	         	true   	true     	                          	mychart1	       
myrelease4	         	true   	true     	id:myrelease1             	mychart1	       

for Helmfile:

commonLabels:
  common: label
environments:
  default:
    values:
     - myrelease2:
         enabled: false
releases:
- name: myrelease1
  chart: mychart1
  installed: no
  labels:
    id: myrelease1
- name: myrelease2
  chart: mychart1
  condition: myrelease2.enabled
- name: myrelease3
  chart: mychart1
  installed: yes
- name: myrelease4
  chart: mychart1
  labels:
    id: myrelease1

Use the value of the `condition` field instead of the `installed` field of a release in the `enabled` column of helmfile list.
The value of the `installed` field is shown in a new `installed` column.

Fixes roboll#1920
@zifter
Copy link

zifter commented Aug 30, 2021

any updates to this isssue?

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still unsure if INSTALLED is the right word because it may be misinterpreted like a flag that indicates if it is actually installed onto the target cluster or not.

But this is much better than the current state! Let's go ahead. Thanks for your contribution.

@mumoshu mumoshu merged commit 346e318 into roboll:master Jan 10, 2022
w33dw0r7d pushed a commit to w33dw0r7d/helmfile that referenced this pull request Mar 8, 2022
Use the value of the `condition` field instead of the `installed` field of a release in the `enabled` column of helmfile list.
The value of the `installed` field is shown in a new `installed` column.

Fixes roboll#1920

Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helmfile list doesn't shows installed as enabled
3 participants