Remove class list dependency for roboflow to detection conversion #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remoed class_list arg from core.py file
|
|
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
hardikdava
changed the title
|
Hi @akashAD98 👋 , thank you for contributing to
|
|
@SkalskiP @capjamesg This might generate conflicts in roboflow server. Please have a look. |
|
@akashAD98 I have fixed class id conversion bug. |
|
@SkalskiP If we want to accept this PR then please fix the tests. |
SkalskiP
added
the
hacktoberfest
|
Hi, @akashAD98 👋🏻! Could you accept the CLA? I'll take care of tests once you do it. |
|
@hardikdava i accepted the CLA |
Updated the prediction parsing logic in supervision/detection/utils.py and supervision/detection/core.py to use 'class_id' instead of 'class' names. Adapted tests in test/detection/test_utils.py accordingly to reflect the same change.
|
@akashAD98 and @hardikdava, I fixed the tests and tested it on example roboflow/inference result, and everything looks fine. We can merge! |
SkalskiP
added
version: 0.15.0
SkalskiP
approved these changes
Oct 4, 2023
|
thanks @SkalskiP |
|
@akashAD98, thanks for help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remoed class_list arg from core.py file
Description
No need to ask user for providing
class_listsimplify the sv.Detections.from_roboflow API and remove extra argument.
solved this issue : #394
Please delete options that are not relevant.
Docs