Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vehicle count notebook with supervison 0.13.0 #190

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

grhaonan
Copy link
Contributor

new version of how-to-track-and-count-vehicles-with-yolov8.ipynb to use the latest Supervision

Description

Please include a summary of the change and which issue is fixed or implemented. Please also include relevant motivation and context (e.g. links, docs, tickets etc.).

List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

I have tested it in colab

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:
    refactoring original notebook code to adapt to Supervision 0.13.0 API

new version of how-to-track-and-count-vehicles-with-yolov8.ipynb to use latest Supervision
@SkalskiP
Copy link
Collaborator

Hi, @grhaonan 👋🏻! Great initial version. Let's do a few additional things before we merge:

Changes in your notebook

  • Change results = model(frame)[0] into results = model(frame, verbose=False)[0]. That will prevent printing YOLOv8 logs. There are two places you'd need to change it.

  • Remove this section:

    ⚠️ YOLOv8 is still under heavy development. Breaking changes are being introduced almost weekly. We strive to make our YOLOv8 notebooks work with the latest version of the library. Last tests took place on 27.08.2023 with version YOLOv8.0.163.

    If you notice that our notebook behaves incorrectly - especially if you experience errors that prevent you from going through the tutorial - don't hesitate! Let us know and open an issue on the Roboflow Notebooks repository.

  • Could we remove tqdm progress bar from your code or present an alternative implementation that would not require the usage of global?

Changes in legacy notebook

  • Remove this section:

    ⚠️ YOLOv8 is still under heavy development. Breaking changes are being introduced almost weekly. We strive to make our YOLOv8 notebooks work with the latest version of the library. Last tests took place on 27.08.2023 with version YOLOv8.0.163.

    If you notice that our notebook behaves incorrectly - especially if you experience errors that prevent you from going through the tutorial - don't hesitate! Let us know and open an issue on the Roboflow Notebooks repository.

  • Remove this section:

    ⚠️ Disclaimer

    YOLOv8 is still under heavy development. Breaking changes are being introduced almost weekly. We strive to make our YOLOv8 notebooks work with the latest version of the library. Last tests took place on 23.01.2023 with version YOLOv8.0.17.

    If you notice that our notebook behaves incorrectly - especially if you experience errors that prevent you from going through the tutorial - don't hesitate! Let us know and open an issue on the Roboflow Notebooks repository.

  • And replace it with:

    This notebook uses legacy versions of ByteTrack and Supervision. To be up to date, use our revamped notebook.

@grhaonan
Copy link
Contributor Author

@SkalskiP thanks for your review and please see the latest commit included.

@grhaonan
Copy link
Contributor Author

grhaonan commented Sep 5, 2023

Good day @SkalskiP , any update on this? thanks

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2023

CLA assistant check
All committers have signed the CLA.

@iturner72
Copy link

Good day @SkalskiP , any update on this? thanks

This worked perfectly for me on my M2 Macbook running locally, thanks for the refactor!

@SkalskiP
Copy link
Collaborator

SkalskiP commented Oct 3, 2023

@iturner72 It's awesome to hear that! 🔥

@SkalskiP
Copy link
Collaborator

SkalskiP commented Oct 3, 2023

@grhaonan, is there a chance you could accept CLA? I'd love to merge this PR. 🔥

@grhaonan
Copy link
Contributor Author

grhaonan commented Oct 3, 2023

@SkalskiP All accepted and thanks for your testing @iturner72

@SkalskiP
Copy link
Collaborator

SkalskiP commented Oct 4, 2023

Looks great! Merging! Thank you @grhaonan! 🙏🏻

@SkalskiP SkalskiP merged commit 3c11c94 into roboflow:main Oct 4, 2023
1 check passed
@grhaonan
Copy link
Contributor Author

grhaonan commented Oct 4, 2023

Thank you all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Contribution] how-to-track-and-count-vehicles-with-yolov8.ipynb updated with latest Supervision 0.13.0 API
5 participants