Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added min_confidence. Fixed bounding box issue. #75

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

sstratoti
Copy link
Contributor

This should fix #58 - It'll allow you to set a min_confidence in the form post similar to how deepstack operates.
I also noticed that my bounding boxes were all out of whack, similar to #62 . I think @robmarkcole was right on the money with the resize to 300x300.

Following this example: https://github.com/google-coral/pycoral/blob/master/examples/detect_image.py

I reworked it so that it didn't resize the image prior to calling interpreter.invoke().
I also borrowed some code to write out how much processing time each run takes, but I commented it out so as not to spam
the log.

I also noticed that you could reference bbox.ymin in the pycoral docs, so I swapped out the bbox[0] so that its a little more clear.

Lastly, I switched out the print for the global interpreter to use a logging.debug instead. This'll print it out to the docker container.

BTW - once a new release is made in this repo, I can update https://github.com/sstratoti/docker-coral-rest-server Dockerfile which I forked from another user and have since updated with some fixes. This is working pretty great so far!

@robmarkcole robmarkcole merged commit cf437f4 into robmarkcole:master Oct 28, 2022
@robmarkcole
Copy link
Owner

Thanks @sstratoti !

@sstratoti
Copy link
Contributor Author

Thanks, https://github.com/sstratoti/docker-coral-rest-server is now updated to use 2.2.
Don't know if I'll be able to maintain it quickly moving forward, but if anyone wants to submit a PR I can merge it real quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bounding boxes with very low confidence.
2 participants