Added a flag url_can_bi_iri that allows disabling IRI parsing #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinst
requested changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linkify by default parses Internationalized Resource Identifiers (IRI) according to
rfc3987. As mentioned in #49 this behavior incorrectly extracts links without scheme when surrounded by Unicode characters without a space, which is valid in some languages. So,地址example.orgis a valid IRI, but the desired behavior is to extract URLexample.org.I added flag to
url_can_be_irithat when set to false disables parsing unicode characters. The default behavior is unchanged.LinkKindis meant to be extendable for other types of links, and I thought addingLinkKind::Iri, but that would make the library backwards incompatible.