Extra tests

robiningelbrecht · Sep 18, 2023 · 7757d1e · 7757d1e
1 parent 7972b60
commit 7757d1e
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 1 deletion.
diff --git a/src/MinCoverage/MinCoverageRules.php b/src/MinCoverage/MinCoverageRules.php
@@ -49,7 +49,7 @@ public static function fromInt(int $minCoverage, bool $exitOnLowCoverage): self
     {
         return new self(
             [new MinCoverageRule(
-                pattern: self::TOTAL,
+                pattern: MinCoverageRule::TOTAL,
                 minCoverage: $minCoverage,
                 exitOnLowCoverage: $exitOnLowCoverage
             )],
@@ -72,6 +72,10 @@ public static function fromConfigFile(string $filePathToConfigFile): self
                 throw new \RuntimeException('Make sure all coverage rules are of instance '.MinCoverageRule::class);
             }
         }
+        $patterns = array_map(fn (MinCoverageRule $minCoverageRule) => $minCoverageRule->getPattern(), $rules);
+        if (count(array_unique($patterns)) !== count($patterns)) {
+            throw new \RuntimeException('Make sure all coverage rule patterns are unique');
+        }
 
         return new self($rules);
     }

diff --git a/tests/Subscriber/Application/ApplicationFinishedSubscriberTest.php b/tests/Subscriber/Application/ApplicationFinishedSubscriberTest.php
@@ -179,6 +179,22 @@ public function testNotifyWithoutTotal(): void
         $this->assertMatchesTextSnapshot($spyOutput);
     }
 
+    public function testNotifyWithDuplicatePatterns(): void
+    {
+        $spyOutput = new SpyOutput();
+
+        $this->expectException(\RuntimeException::class);
+        $this->expectExceptionMessage('Make sure all coverage rule patterns are unique');
+
+        new ApplicationFinishedSubscriber(
+            relativePathToCloverXml: 'tests/clover.xml',
+            minCoverageRules: MinCoverageRules::fromConfigFile('tests/Subscriber/Application/min-coverage-rules-with-duplicates.php'),
+            cleanUpCloverXml: false,
+            exitter: new Exitter(),
+            consoleOutput: new ConsoleOutput($spyOutput),
+        );
+    }
+
     public function testNotifyWithInvalidRules(): void
     {
         $spyOutput = new SpyOutput();

diff --git a/tests/Subscriber/Application/min-coverage-rules-with-duplicates.php b/tests/Subscriber/Application/min-coverage-rules-with-duplicates.php
@@ -0,0 +1,16 @@
+<?php
+
+use RobinIngelbrecht\PHPUnitCoverageTools\MinCoverage\MinCoverageRule;
+
+return [
+    new MinCoverageRule(
+        pattern: 'RobinIngelbrecht\PHPUnitCoverageTools\PhpUnitExtension',
+        minCoverage: 100,
+        exitOnLowCoverage: true
+    ),
+    new MinCoverageRule(
+        pattern: 'RobinIngelbrecht\PHPUnitCoverageTools\PhpUnitExtension',
+        minCoverage: 100,
+        exitOnLowCoverage: true
+    ),
+];