Skip to content

Commit

Permalink
Fixed bug while determining --clean-up-clover-xml
Browse files Browse the repository at this point in the history
  • Loading branch information
@robiningelbrecht
robiningelbrecht committed May 1, 2023
1 parent 06e52ad commit 60fefb8
Show file tree
Hide file tree
Showing 3 changed files with 309 additions and 3 deletions.
306 changes: 306 additions & 0 deletions clover.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,306 @@
<?xml version="1.0" encoding="UTF-8"?>
<coverage generated="1682956204">
<project timestamp="1682956204">
<file name="/var/www/src/ConsoleOutput.php">
<class name="RobinIngelbrecht\PHPUnitCoverageTools\ConsoleOutput" namespace="global">
<metrics complexity="3" methods="2" coveredmethods="2" conditionals="0" coveredconditionals="0" statements="52" coveredstatements="52" elements="54" coveredelements="54"/>
</class>
<line num="17" type="method" name="__construct" visibility="public" complexity="1" crap="1" count="10"/>
<line num="20" type="stmt" count="10"/>
<line num="21" type="stmt" count="10"/>
<line num="22" type="stmt" count="10"/>
<line num="23" type="stmt" count="10"/>
<line num="24" type="stmt" count="10"/>
<line num="25" type="stmt" count="10"/>
<line num="26" type="stmt" count="10"/>
<line num="27" type="stmt" count="10"/>
<line num="28" type="stmt" count="10"/>
<line num="29" type="stmt" count="10"/>
<line num="30" type="stmt" count="10"/>
<line num="31" type="stmt" count="10"/>
<line num="32" type="stmt" count="10"/>
<line num="33" type="stmt" count="10"/>
<line num="34" type="stmt" count="10"/>
<line num="35" type="stmt" count="10"/>
<line num="36" type="stmt" count="10"/>
<line num="42" type="method" name="print" visibility="public" complexity="2" crap="2" count="5"/>
<line num="44" type="stmt" count="5"/>
<line num="45" type="stmt" count="5"/>
<line num="46" type="stmt" count="5"/>
<line num="47" type="stmt" count="5"/>
<line num="48" type="stmt" count="5"/>
<line num="50" type="stmt" count="5"/>
<line num="51" type="stmt" count="5"/>
<line num="52" type="stmt" count="5"/>
<line num="53" type="stmt" count="5"/>
<line num="54" type="stmt" count="5"/>
<line num="55" type="stmt" count="5"/>
<line num="56" type="stmt" count="5"/>
<line num="57" type="stmt" count="5"/>
<line num="58" type="stmt" count="5"/>
<line num="59" type="stmt" count="5"/>
<line num="60" type="stmt" count="5"/>
<line num="61" type="stmt" count="5"/>
<line num="62" type="stmt" count="5"/>
<line num="63" type="stmt" count="5"/>
<line num="64" type="stmt" count="5"/>
<line num="65" type="stmt" count="5"/>
<line num="66" type="stmt" count="5"/>
<line num="67" type="stmt" count="5"/>
<line num="68" type="stmt" count="5"/>
<line num="69" type="stmt" count="5"/>
<line num="70" type="stmt" count="5"/>
<line num="71" type="stmt" count="5"/>
<line num="72" type="stmt" count="5"/>
<line num="73" type="stmt" count="5"/>
<line num="74" type="stmt" count="5"/>
<line num="75" type="stmt" count="5"/>
<line num="76" type="stmt" count="5"/>
<line num="77" type="stmt" count="5"/>
<line num="78" type="stmt" count="5"/>
<line num="79" type="stmt" count="5"/>
<metrics loc="82" ncloc="79" classes="1" methods="2" coveredmethods="2" conditionals="0" coveredconditionals="0" statements="52" coveredstatements="52" elements="54" coveredelements="54"/>
</file>
<file name="/var/www/src/MinCoverage/CoverageMetric.php">
<class name="RobinIngelbrecht\PHPUnitCoverageTools\MinCoverage\CoverageMetric" namespace="global">
<metrics complexity="12" methods="12" coveredmethods="12" conditionals="0" coveredconditionals="0" statements="24" coveredstatements="24" elements="36" coveredelements="36"/>
</class>
<line num="7" type="method" name="__construct" visibility="private" complexity="1" crap="1" count="5"/>
<line num="18" type="stmt" count="5"/>
<line num="20" type="method" name="getForClass" visibility="public" complexity="1" crap="1" count="4"/>
<line num="22" type="stmt" count="4"/>
<line num="25" type="method" name="getNumberOfMethods" visibility="public" complexity="1" crap="1" count="5"/>
<line num="27" type="stmt" count="5"/>
<line num="30" type="method" name="getNumberOfCoveredMethods" visibility="public" complexity="1" crap="1" count="5"/>
<line num="32" type="stmt" count="5"/>
<line num="35" type="method" name="getNumberOfStatements" visibility="public" complexity="1" crap="1" count="5"/>
<line num="37" type="stmt" count="5"/>
<line num="40" type="method" name="getNumberOfCoveredStatements" visibility="public" complexity="1" crap="1" count="5"/>
<line num="42" type="stmt" count="5"/>
<line num="45" type="method" name="getNumberOfConditionals" visibility="public" complexity="1" crap="1" count="5"/>
<line num="47" type="stmt" count="5"/>
<line num="50" type="method" name="getNumberOfCoveredConditionals" visibility="public" complexity="1" crap="1" count="5"/>
<line num="52" type="stmt" count="5"/>
<line num="55" type="method" name="getNumberOfTrackedLines" visibility="public" complexity="1" crap="1" count="5"/>
<line num="57" type="stmt" count="5"/>
<line num="60" type="method" name="getNumberOfCoveredLines" visibility="public" complexity="1" crap="1" count="5"/>
<line num="62" type="stmt" count="5"/>
<line num="65" type="method" name="getTotalPercentageCoverage" visibility="public" complexity="1" crap="1" count="5"/>
<line num="70" type="stmt" count="5"/>
<line num="71" type="stmt" count="5"/>
<line num="74" type="method" name="fromCloverXmlNode" visibility="public" complexity="1" crap="1" count="5"/>
<line num="77" type="stmt" count="5"/>
<line num="79" type="stmt" count="5"/>
<line num="80" type="stmt" count="5"/>
<line num="81" type="stmt" count="5"/>
<line num="82" type="stmt" count="5"/>
<line num="83" type="stmt" count="5"/>
<line num="84" type="stmt" count="5"/>
<line num="85" type="stmt" count="5"/>
<line num="86" type="stmt" count="5"/>
<line num="87" type="stmt" count="5"/>
<line num="88" type="stmt" count="5"/>
<line num="89" type="stmt" count="5"/>
<metrics loc="92" ncloc="89" classes="1" methods="12" coveredmethods="12" conditionals="0" coveredconditionals="0" statements="24" coveredstatements="24" elements="36" coveredelements="36"/>
</file>
<file name="/var/www/src/MinCoverage/MinCoverageResult.php">
<class name="RobinIngelbrecht\PHPUnitCoverageTools\MinCoverage\MinCoverageResult" namespace="global">
<metrics complexity="18" methods="9" coveredmethods="9" conditionals="0" coveredconditionals="0" statements="49" coveredstatements="49" elements="58" coveredelements="58"/>
</class>
<line num="7" type="method" name="__construct" visibility="private" complexity="1" crap="1" count="5"/>
<line num="14" type="stmt" count="5"/>
<line num="16" type="method" name="getPattern" visibility="public" complexity="1" crap="1" count="5"/>
<line num="18" type="stmt" count="5"/>
<line num="21" type="method" name="getStatus" visibility="public" complexity="3" crap="3" count="5"/>
<line num="23" type="stmt" count="5"/>
<line num="24" type="stmt" count="3"/>
<line num="27" type="stmt" count="5"/>
<line num="30" type="method" name="getExpectedMinCoverage" visibility="public" complexity="1" crap="1" count="5"/>
<line num="32" type="stmt" count="5"/>
<line num="35" type="method" name="getActualMinCoverage" visibility="public" complexity="1" crap="1" count="5"/>
<line num="37" type="stmt" count="5"/>
<line num="40" type="method" name="getNumberOfTrackedLines" visibility="public" complexity="1" crap="1" count="5"/>
<line num="42" type="stmt" count="5"/>
<line num="45" type="method" name="getNumberOfCoveredLines" visibility="public" complexity="1" crap="1" count="5"/>
<line num="47" type="stmt" count="5"/>
<line num="50" type="method" name="fromPatternAndNumbers" visibility="public" complexity="1" crap="1" count="5"/>
<line num="57" type="stmt" count="5"/>
<line num="58" type="stmt" count="5"/>
<line num="59" type="stmt" count="5"/>
<line num="60" type="stmt" count="5"/>
<line num="61" type="stmt" count="5"/>
<line num="62" type="stmt" count="5"/>
<line num="63" type="stmt" count="5"/>
<line num="71" type="method" name="mapFromRulesAndMetrics" visibility="public" complexity="8" crap="8" count="5"/>
<line num="76" type="stmt" count="5"/>
<line num="77" type="stmt" count="5"/>
<line num="78" type="stmt" count="5"/>
<line num="79" type="stmt" count="5"/>
<line num="80" type="stmt" count="5"/>
<line num="81" type="stmt" count="5"/>
<line num="82" type="stmt" count="5"/>
<line num="83" type="stmt" count="5"/>
<line num="84" type="stmt" count="5"/>
<line num="85" type="stmt" count="5"/>
<line num="86" type="stmt" count="5"/>
<line num="89" type="stmt" count="4"/>
<line num="90" type="stmt" count="4"/>
<line num="91" type="stmt" count="4"/>
<line num="93" type="stmt" count="4"/>
<line num="94" type="stmt" count="4"/>
<line num="95" type="stmt" count="3"/>
<line num="96" type="stmt" count="3"/>
<line num="99" type="stmt" count="4"/>
<line num="100" type="stmt" count="4"/>
<line num="101" type="stmt" count="4"/>
<line num="102" type="stmt" count="4"/>
<line num="103" type="stmt" count="4"/>
<line num="104" type="stmt" count="4"/>
<line num="105" type="stmt" count="4"/>
<line num="108" type="stmt" count="5"/>
<line num="109" type="stmt" count="4"/>
<line num="110" type="stmt" count="4"/>
<line num="112" type="stmt" count="2"/>
<line num="113" type="stmt" count="2"/>
<line num="116" type="stmt" count="2"/>
<line num="117" type="stmt" count="5"/>
<line num="119" type="stmt" count="5"/>
<metrics loc="122" ncloc="117" classes="1" methods="9" coveredmethods="9" conditionals="0" coveredconditionals="0" statements="49" coveredstatements="49" elements="58" coveredelements="58"/>
</file>
<file name="/var/www/src/MinCoverage/MinCoverageRules.php">
<class name="RobinIngelbrecht\PHPUnitCoverageTools\MinCoverage\MinCoverageRules" namespace="global">
<metrics complexity="14" methods="6" coveredmethods="6" conditionals="0" coveredconditionals="0" statements="21" coveredstatements="21" elements="27" coveredelements="27"/>
</class>
<line num="11" type="method" name="__construct" visibility="private" complexity="1" crap="1" count="11"/>
<line num="15" type="stmt" count="11"/>
<line num="20" type="method" name="getRules" visibility="public" complexity="1" crap="1" count="9"/>
<line num="22" type="stmt" count="9"/>
<line num="25" type="method" name="hasTotalRule" visibility="public" complexity="1" crap="1" count="6"/>
<line num="27" type="stmt" count="6"/>
<line num="30" type="method" name="hasOtherRulesThanTotalRule" visibility="public" complexity="3" crap="3" count="6"/>
<line num="32" type="stmt" count="6"/>
<line num="33" type="stmt" count="6"/>
<line num="34" type="stmt" count="5"/>
<line num="38" type="stmt" count="1"/>
<line num="41" type="method" name="fromInt" visibility="public" complexity="3" crap="3" count="3"/>
<line num="43" type="stmt" count="3"/>
<line num="44" type="stmt" count="1"/>
<line num="47" type="stmt" count="2"/>
<line num="48" type="stmt" count="2"/>
<line num="49" type="stmt" count="2"/>
<line num="52" type="method" name="fromConfigFile" visibility="public" complexity="5" crap="5" count="11"/>
<line num="55" type="stmt" count="11"/>
<line num="56" type="stmt" count="11"/>
<line num="58" type="stmt" count="11"/>
<line num="59" type="stmt" count="1"/>
<line num="62" type="stmt" count="10"/>
<line num="63" type="stmt" count="10"/>
<line num="64" type="stmt" count="9"/>
<line num="65" type="stmt" count="1"/>
<line num="69" type="stmt" count="9"/>
<metrics loc="72" ncloc="67" classes="1" methods="6" coveredmethods="6" conditionals="0" coveredconditionals="0" statements="21" coveredstatements="21" elements="27" coveredelements="27"/>
</file>
<file name="/var/www/src/MinCoverage/ResultStatus.php">
<class name="RobinIngelbrecht\PHPUnitCoverageTools\MinCoverage\ResultStatus" namespace="global">
<metrics complexity="2" methods="2" coveredmethods="2" conditionals="0" coveredconditionals="0" statements="10" coveredstatements="10" elements="12" coveredelements="12"/>
</class>
<line num="11" type="method" name="getWeight" visibility="public" complexity="1" crap="1" count="2"/>
<line num="13" type="stmt" count="2"/>
<line num="14" type="stmt" count="2"/>
<line num="15" type="stmt" count="2"/>
<line num="16" type="stmt" count="2"/>
<line num="17" type="stmt" count="2"/>
<line num="20" type="method" name="getMessage" visibility="public" complexity="1" crap="1" count="5"/>
<line num="22" type="stmt" count="5"/>
<line num="23" type="stmt" count="5"/>
<line num="24" type="stmt" count="5"/>
<line num="25" type="stmt" count="5"/>
<line num="26" type="stmt" count="5"/>
<metrics loc="29" ncloc="29" classes="1" methods="2" coveredmethods="2" conditionals="0" coveredconditionals="0" statements="10" coveredstatements="10" elements="12" coveredelements="12"/>
</file>
<file name="/var/www/src/PhpUnitExtension.php">
<class name="RobinIngelbrecht\PHPUnitCoverageTools\PhpUnitExtension" namespace="global">
<metrics complexity="2" methods="1" coveredmethods="1" conditionals="0" coveredconditionals="0" statements="9" coveredstatements="9" elements="10" coveredelements="10"/>
</class>
<line num="13" type="method" name="bootstrap" visibility="public" complexity="2" crap="2" count="3"/>
<line num="18" type="stmt" count="3"/>
<line num="19" type="stmt" count="3"/>
<line num="20" type="stmt" count="3"/>
<line num="21" type="stmt" count="3"/>
<line num="22" type="stmt" count="3"/>
<line num="23" type="stmt" count="2"/>
<line num="26" type="stmt" count="1"/>
<line num="27" type="stmt" count="1"/>
<line num="28" type="stmt" count="1"/>
<metrics loc="31" ncloc="31" classes="1" methods="1" coveredmethods="1" conditionals="0" coveredconditionals="0" statements="9" coveredstatements="9" elements="10" coveredelements="10"/>
</file>
<file name="/var/www/src/Subscriber/Application/ApplicationFinishedSubscriber.php">
<class name="RobinIngelbrecht\PHPUnitCoverageTools\Subscriber\Application\ApplicationFinishedSubscriber" namespace="global">
<metrics complexity="29" methods="3" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="58" coveredstatements="58" elements="61" coveredelements="61"/>
</class>
<line num="20" type="method" name="__construct" visibility="public" complexity="1" crap="1" count="10"/>
<line num="28" type="stmt" count="10"/>
<line num="30" type="method" name="notify" visibility="public" complexity="16" crap="16" count="7"/>
<line num="33" type="stmt" count="7"/>
<line num="34" type="stmt" count="7"/>
<line num="36" type="stmt" count="7"/>
<line num="37" type="stmt" count="1"/>
<line num="41" type="stmt" count="6"/>
<line num="42" type="stmt" count="6"/>
<line num="45" type="stmt" count="6"/>
<line num="46" type="stmt" count="6"/>
<line num="47" type="stmt" count="6"/>
<line num="48" type="stmt" count="6"/>
<line num="50" type="stmt" count="5"/>
<line num="51" type="stmt" count="5"/>
<line num="52" type="stmt" count="5"/>
<line num="55" type="stmt" count="6"/>
<line num="57" type="stmt" count="4"/>
<line num="59" type="stmt" count="4"/>
<line num="60" type="stmt" count="4"/>
<line num="63" type="stmt" count="6"/>
<line num="65" type="stmt" count="6"/>
<line num="66" type="stmt" count="1"/>
<line num="69" type="stmt" count="6"/>
<line num="70" type="stmt" count="1"/>
<line num="73" type="stmt" count="5"/>
<line num="74" type="stmt" count="5"/>
<line num="75" type="stmt" count="5"/>
<line num="76" type="stmt" count="5"/>
<line num="77" type="stmt" count="5"/>
<line num="78" type="stmt" count="5"/>
<line num="80" type="stmt" count="5"/>
<line num="82" type="stmt" count="5"/>
<line num="83" type="stmt" count="2"/>
<line num="90" type="method" name="fromConfigurationAndParameters" visibility="public" complexity="12" crap="12" count="8"/>
<line num="95" type="stmt" count="8"/>
<line num="96" type="stmt" count="1"/>
<line num="99" type="stmt" count="7"/>
<line num="100" type="stmt" count="7"/>
<line num="101" type="stmt" count="7"/>
<line num="102" type="stmt" count="2"/>
<line num="106" type="stmt" count="6"/>
<line num="107" type="stmt" count="3"/>
<line num="108" type="stmt" count="2"/>
<line num="111" type="stmt" count="3"/>
<line num="112" type="stmt" count="3"/>
<line num="113" type="stmt" count="2"/>
<line num="115" type="stmt" count="2"/>
<line num="116" type="stmt" count="2"/>
<line num="120" type="stmt" count="5"/>
<line num="121" type="stmt" count="2"/>
<line num="124" type="stmt" count="3"/>
<line num="125" type="stmt" count="2"/>
<line num="128" type="stmt" count="3"/>
<line num="129" type="stmt" count="3"/>
<line num="130" type="stmt" count="3"/>
<line num="131" type="stmt" count="3"/>
<line num="132" type="stmt" count="3"/>
<line num="133" type="stmt" count="3"/>
<line num="134" type="stmt" count="3"/>
<line num="135" type="stmt" count="3"/>
<metrics loc="138" ncloc="129" classes="1" methods="3" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="58" coveredstatements="58" elements="61" coveredelements="61"/>
</file>
<metrics files="7" loc="566" ncloc="541" classes="7" methods="35" coveredmethods="35" conditionals="0" coveredconditionals="0" statements="223" coveredstatements="223" elements="258" coveredelements="258"/>
</project>
</coverage>
2 changes: 1 addition & 1 deletion src/Subscriber/Application/ApplicationFinishedSubscriber.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public static function fromConfigurationAndParameters(
return null;
}

if (!$cleanUpCloverXml = in_array('--clean-up-clover-xml', $_SERVER['argv'], true)) {
if (!$cleanUpCloverXml = in_array('--clean-up-clover-xml', $args, true)) {
$cleanUpCloverXml = $parameters->has('cleanUpCloverXml') && (int) $parameters->get('cleanUpCloverXml');
}

Expand Down
4 changes: 2 additions & 2 deletions tests/Subscriber/Application/ApplicationFinishedSubscriberTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ public function testFromConfigurationAndParameters(): void
'tests/clover.xml',
MinCoverageRules::fromInt(90),
false,
false,
true,
new Exitter(),
new ConsoleOutput(new \Symfony\Component\Console\Output\ConsoleOutput()),
),
Expand All @@ -289,7 +289,7 @@ public function testFromConfigurationAndParameters(): void
'--coverage-clover=tests/clover.xml',
]),
ParameterCollection::fromArray([]),
['--min-coverage=90']
['--min-coverage=90', '--clean-up-clover-xml']
),
);
}
Expand Down

0 comments on commit 60fefb8

Please sign in to comment.