Merge pull request #5 from robiningelbrecht/fix-final-status-bug

Fix final status bug
robiningelbrecht · Sep 13, 2023 · 4be207c · 4be207c
2 parents 3eef6d6 + 8fb6565
commit 4be207c
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 3 deletions.
diff --git a/src/MinCoverage/ResultStatus.php b/src/MinCoverage/ResultStatus.php
@@ -8,6 +8,16 @@ enum ResultStatus: string
     case WARNING = 'warning';
     case FAILED = 'failed';
 
+    public static function fromWeight(int $weight): self
+    {
+        return match ($weight) {
+            1 => self::SUCCESS ,
+            2 => self::WARNING,
+            3 => self::FAILED,
+            default => throw new \InvalidArgumentException('Invalid weight '.$weight),
+        };
+    }
+
     public function getWeight(): int
     {
         return match ($this) {

diff --git a/src/Subscriber/Application/ApplicationFinishedSubscriber.php b/src/Subscriber/Application/ApplicationFinishedSubscriber.php
@@ -74,7 +74,10 @@ public function notify(Finished $event): void
             metrics: $metrics,
             metricTotal: $metricTotal,
         );
-        $finalStatus = array_values($results)[0]->getStatus();
+        $statusWeights = array_map(fn (MinCoverageResult $result) => $result->getStatus()->getWeight(), $results);
+        rsort($statusWeights, SORT_NUMERIC);
+
+        $finalStatus = ResultStatus::fromWeight($statusWeights[0]);
 
         $this->consoleOutput->print($results, $finalStatus);
 

diff --git a/tests/Subscriber/Application/ApplicationFinishedSubscriberTest.php b/tests/Subscriber/Application/ApplicationFinishedSubscriberTest.php
@@ -123,7 +123,7 @@ public function testNotifyWhenCoverageIsOk(): void
         $this->assertMatchesTextSnapshot($spyOutput);
     }
 
-    public function testNotifyWhitOnlyTotal(): void
+    public function testNotifyWithOnlyTotal(): void
     {
         $spyOutput = new SpyOutput();
         $subscriber = new ApplicationFinishedSubscriber(
@@ -154,7 +154,7 @@ public function testNotifyWhitOnlyTotal(): void
         $this->assertMatchesTextSnapshot($spyOutput);
     }
 
-    public function testNotifyWhitInvalidRules(): void
+    public function testNotifyWithInvalidRules(): void
     {
         $spyOutput = new SpyOutput();
 

diff --git a/...riberTest__testNotifyWhitOnlyTotal__1.txt → ...riberTest__testNotifyWithOnlyTotal__1.txt b/...riberTest__testNotifyWhitOnlyTotal__1.txt → ...riberTest__testNotifyWithOnlyTotal__1.txt