Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump node-mbus@2.1.0 #40

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

petrkr
Copy link
Contributor

@petrkr petrkr commented Mar 8, 2024

Build on actual LTS NodeJS 20 and actuall nodejs ends with error. It uses historical version of node-mbus, so simple update to latest 2.1.0 version helped

npm ERR! In file included from ../../nan/nan.h:176,
npm ERR!                  from ../src/main.cc:1:
npm ERR! ../../nan/nan_callbacks.h:55:23: error: ‘AccessorSignature’ is not a member of ‘v8’
npm ERR!    55 | typedef v8::Local<v8::AccessorSignature> Sig;
npm ERR!       |                       ^~~~~~~~~~~~~~~~~
npm ERR! ../../nan/nan_callbacks.h:55:40: error: template argument 1 is invalid
npm ERR!    55 | typedef v8::Local<v8::AccessorSignature> Sig;
npm ERR!       |                                        ^
npm ERR! In file included from ../src/main.cc:1:
npm ERR! ../../nan/nan.h: In function ‘void Nan::SetAccessor(v8::Local<v8::ObjectTemplate>, v8::Local<v8::String>, Nan::GetterCallback, Nan::SetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, Nan::imp::Sig)’:
npm ERR! ../../nan/nan.h:2549:16: error: no matching function for call to ‘v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>&, void (*&)(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&), void (*&)(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&), v8::Local<v8::Object>&, v8::AccessControl&, v8::PropertyAttribute&, Nan::imp::Sig&)’
npm ERR!  2549 |     , signature);
npm ERR!       |                ^
npm ERR! In file included from /opt/nodered/.cache/node-gyp/20.11.1/include/node/v8-function.h:15,
npm ERR!                  from /opt/nodered/.cache/node-gyp/20.11.1/include/node/v8.h:33,
npm ERR!                  from /opt/nodered/.cache/node-gyp/20.11.1/include/node/node.h:73,
npm ERR!                  from ../../nan/nan.h:56,
npm ERR!                  from ../src/main.cc:1:

Copy link
Owner

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should run npm install to update package-lock as well

@petrkr
Copy link
Contributor Author

petrkr commented Mar 8, 2024

Sorry I am not familiar with NodeJS system, from documentation I read lock file is generated on install, so I do not understand why It must be in repository as it is dynamically generated file.

I tested it on my instance where I did also npm install

@petrkr
Copy link
Contributor Author

petrkr commented Mar 8, 2024

Hello'
force pushed new version, so it will not do extra commits. This is right ?

Regards Petr

Copy link
Owner

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep seems ok now, thanks

@robertsLando robertsLando changed the title Update node-mbus version, FIX build chore: bump node-mbus@2.1.0 Mar 11, 2024
@robertsLando robertsLando merged commit 05839a6 into robertsLando:master Mar 11, 2024
3 checks passed
@robertsLando
Copy link
Owner

@petrkr Just released 3.1.0 version

@petrkr petrkr deleted the fixbuild branch March 11, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants