feat: use exported methods when setting go values #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
force-pushed
the
feat/use-exported-values
branch
from
de7f9b4
to
e152fee
Compare
sg3des
pushed a commit
to sg3des/otto
that referenced
this pull request
Jul 17, 2023
When putting JavaScript objects into _go*object use exported values. This reverts PR robertkrimen#467 in favour of this more complete work. Fixes robertkrimen#118 robertkrimen#252 Co-authored-by: Dmitry Panov <dop@itoolabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When putting JavaScript objects into _go*object use exported values. This reverts PR #467 in favour of this more complete work.
Fixes #118 #252
Co-authored-by: Dmitry Panov dop@itoolabs.com