fix: array writes #454
Merged
fix: array writes #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
force-pushed
the
fix/array-set
branch
from
4382e69
to
8d32972
Compare
Fix array writes not being persisted by passing in writeable reflect.Value when available instead of .Interface() which looses that property. Also: * Use value.IsValid() instead of comparison with zero entry. * Use propertyLength instead of literal. Fixes #386
stevenh
force-pushed
the
fix/array-set
branch
from
8d32972
to
b6dd45a
Compare
sg3des
pushed a commit
to sg3des/otto
that referenced
this pull request
Jul 17, 2023
Fix array writes not being persisted by passing in writeable reflect.Value when available instead of .Interface() which looses that property. Also: * Use value.IsValid() instead of comparison with zero entry. * Use propertyLength instead of literal. Fixes robertkrimen#386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix array writes not being persisted by passing in writeable reflect.Value when available instead of .Interface() which looses that property.
Also:
Fixes #386