Generate a package using Rollup #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `yarn package` command that builds a package. Making the output of TypeScript compilation work as rollup input required changing the TS module output type to native ES modules. This currently breaks test execution. That will be fixed in the next commit.
Use native ES modules everywhere for consistency between source and tests and to allow the output of TypeScript compilation to function both as input to Rollup packaging and execution by mocha. Node ES module support requires that file extensions are always explicitly specified. TypeScript does not generate the ".js" extension itself but counter-intuitively does allow it to be specified in the original source [1]. [1] microsoft/TypeScript#42151 (comment)
Setting the package's `type` field affects how it is loaded both in development and also when importing it directly using Node. Let's try making it an ES module when published as well.
robertknight
force-pushed
the
rollup-package
branch
from
55c4b8f
to
695227e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile all the modules into a single package in the
dist/directory using Rollup.To do this with minimal adding tooling required changing TypeScript compilation to output native ES modules into the
build/directory. This in turn required changing the whole package to a native ES module package by editing thetypefield inpackage.jsonand rewriting import specifiers to include a file extension.Somewhat confusingly, the extension in the .ts source files needs to end in .js. See microsoft/TypeScript#42151 (comment).