Fix panic in layout analysis when average word spacing in a line is negative #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egative Word detection can produce words which have a small overlap. This is because the detection model predicts boxes which are slightly shrunk from their true size, and post-processing then pads the boxes to recover the "true" size. This means it is possible for the average inter-word spacing in a line to be negative. When this happens a panic occurred when converting the spacing from signed to unsigned. Fixes #19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Word detection can produce words which have a small overlap. This is because the detection model predicts boxes which are slightly shrunk from their true size, and post-processing then pads the boxes to recover the "true" size.
This means it is possible for the average inter-word spacing in a line to be negative. When this happens a panic occurred when converting the spacing from signed to unsigned.
The fix is just to clamp the computed average spacing to be >= 0.
Fixes #19